Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nanoID with pure JS function #56

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Replace nanoID with pure JS function #56

merged 6 commits into from
Oct 14, 2024

Conversation

flor-master
Copy link
Collaborator

@flor-master flor-master commented Oct 10, 2024 •
edited
Loading

Description

Replace nanoID with vanilla JS function

Motivation and Context

Remove unnecessary depending

How Has This Been Tested?

Create additional tests

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@flor-master flor-master merged commit 110e035 into verygoodsecurity:main Oct 14, 2024
@flor-master flor-master deleted the CSL3-2371 branch October 14, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaKudriasheva AnnaKudriasheva AnnaKudriasheva approved these changes

@vivalafit vivalafit vivalafit approved these changes

@dmarynych dmarynych Awaiting requested review from dmarynych

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flor-master @AnnaKudriasheva @vivalafit