Feature alpha mask #111
Merged
Feature alpha mask #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yslib
force-pushed
the
feature-alpha-mask
branch
from
26bc8f5 to
05b8910
Compare
harry75369
reviewed
Oct 25, 2023
src/Layer/PaintNode.cpp
Outdated
| auto r = SkRuntimeEffect::MakeForShader(SkString(R"( | ||
| uniform shader content; | ||
| uniform shader bg; | ||
| uniform float2 size; |
src/Layer/PaintNode.cpp
Outdated
| DEBUG("%s", r.errorText.c_str()); | ||
| return nullptr; | ||
| } | ||
| SkRuntimeShaderBuilder builder(std::move(r.effect)); |
There was a problem hiding this comment.
Could this builder be static and be initialized only once?
| else if (*blurType == BT_Zoom) | ||
| DEBUG("Zoom blur has not been implemeted"); | ||
| else if (*blurType == BT_Motion) | ||
| DEBUG("Zoom blur has not been implemeted"); |
There was a problem hiding this comment.
Should be Motion blur has not been implemented
| else if (*blurType == BT_Background) | ||
| painter.blurBackgroundEnd(); | ||
| else if (*blurType == BT_Zoom) | ||
| DEBUG("Zoom blur has not been implemeted"); |
| std::ofstream ofs(*m_skpPath); | ||
| if (ofs.is_open()) | ||
| { | ||
| ofs.write((char*)data->data(), data->size()); |
There was a problem hiding this comment.
This may have potential issue with wasm version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for alpha mask and background blur