Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejigger the the cell backup so it blocks the ioloop less #2145

Merged
merged 5 commits into from
Apr 9, 2021

Conversation

jnwatson
Copy link
Contributor

@jnwatson jnwatson commented Apr 6, 2021

No description provided.

synapse/lib/cell.py Show resolved Hide resolved
@vEpiphyte
Copy link
Contributor

vEpiphyte commented Apr 8, 2021

Tests broken due to jupyter/jupyter_client#637

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #2145 (b2855c0) into master (96521d9) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2145      +/-   ##
==========================================
- Coverage   97.11%   96.97%   -0.14%     
==========================================
  Files         154      154              
  Lines       31207    31203       -4     
==========================================
- Hits        30306    30260      -46     
- Misses        901      943      +42     
Flag Coverage Δ
linux 96.97% <100.00%> (-0.14%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/cell.py 97.88% <100.00%> (-0.02%) ⬇️
synapse/lib/nexus.py 96.99% <100.00%> (+0.02%) ⬆️
synapse/tests/utils.py 93.77% <0.00%> (-2.12%) ⬇️
synapse/lib/hiveauth.py 96.18% <0.00%> (-0.73%) ⬇️
synapse/cortex.py 96.20% <0.00%> (-0.71%) ⬇️
synapse/lib/view.py 94.18% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 94.11% <0.00%> (-0.43%) ⬇️
synapse/lib/layer.py 98.11% <0.00%> (-0.06%) ⬇️
synapse/lib/hive.py 98.31% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96521d9...b2855c0. Read the comment docs.

@jnwatson jnwatson merged commit c2a0c75 into master Apr 9, 2021
@jnwatson jnwatson deleted the backup-lock branch April 9, 2021 00:11
@vEpiphyte vEpiphyte added this to the v2.33.0 milestone Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants