Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape URLs in EPUB 2 NCX and EPUB 3 navigation documents #98

Merged
merged 1 commit into from
May 27, 2023

Conversation

vers-one
Copy link
Owner

Unescape URLs in EPUB 2 NCX and EPUB 3 navigation documents

This is:

  • a bug fix
  • an enhancement

Related issue: #97

Description

This pull request moves URL unescaping from NavigationReader to Epub2NcxReader and Epub3NavDocumentReader to make sure that instances of Epub2Ncx and Epub3NavDocument types contain unescaped URLs.

Testing steps

Three new unit tests have been added to test unescaping URLs.

@vers-one vers-one self-assigned this May 27, 2023
@vers-one vers-one linked an issue May 27, 2023 that may be closed by this pull request
@vers-one vers-one merged commit 1d3ae21 into master May 27, 2023
@vers-one vers-one deleted the unescape branch May 27, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unescape URLs in EPUB 2 NCX and EPUB 3 navigation documents
1 participant