Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationReader fix: get content files via absolute file paths #92

Merged
merged 6 commits into from
May 19, 2023

Conversation

vers-one
Copy link
Owner

NavigationReader fix: get content files via absolute file paths

This is:

  • a bug fix
  • an enhancement

Related issue: #91

Description

This pull request:

  1. Fixes an issue with obtaining a content file in NavigationReader when OPF and navigation files are located in different subdirectories.
  2. Refactors EpubContentCollection and EpubContentCollectionRef classes to provide a way for an application to obtain a content file by its key as well as by its absolute path.

Testing steps

Open a EPUB book which has OPF and navigation files located in different subdirectories.

@vers-one vers-one marked this pull request as ready for review May 19, 2023 06:16
@vers-one vers-one merged commit 67fadc9 into master May 19, 2023
@vers-one vers-one deleted the navigation-fix branch May 19, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant