Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote manifest items support, part 1 #62

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Remote manifest items support, part 1 #62

merged 1 commit into from
Sep 18, 2022

Conversation

vers-one
Copy link
Owner

@vers-one vers-one commented Sep 18, 2022

Remote manifest items support, part 1

This is:

  • a bug fix
  • an enhancement

Related issue: #61

Description

This pull request adds support for remote manifest items (i.e. files referenced by absolute URLs like http://example.com/book/123/chapter1.html as opposed to local files like Content/chapter1.html which are packaged within the EPUB file).

Testing steps

Try to open a EPUB book with the following manifest items:

<manifest>
  <item id="item-1" href="https://example.com/books/123/test.html" media-type="application/xhtml+xml" />
  <item id="item-2" href="https://example.com/books/123/image.jpg" media-type="image/jpeg" />
  ...
</manifest>

@vers-one vers-one self-assigned this Sep 18, 2022
@vers-one vers-one linked an issue Sep 18, 2022 that may be closed by this pull request
@vers-one vers-one merged commit 7441243 into master Sep 18, 2022
@vers-one vers-one deleted the remote-items branch September 18, 2022 08:10
@vers-one vers-one changed the title Remote manifest items support Remote manifest items support, part 1 Nov 7, 2022
@vers-one vers-one mentioned this pull request Nov 7, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote manifest items support
1 participant