Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configurable deployment strategy #163

Merged
merged 3 commits into from
Dec 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.7
python-version: '3.x'
check-latest: true

- name: Set up chart-testing
uses: helm/chart-testing-action@v2.6.1
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ and their default values.
| `priorityClass.name` | PriorityClassName to be specified in pod spec | `""` |
| `replicaCount` | Desired number of pods | `1` |
| `replicaCountEnabled` | Enable the replicaCount field | `true` |
| `strategy` | The deployment strategy field | If persistence is enabled, the strategy type is set to `Recreate`, otherwise `RollingUpdate` |
| `livenessProbe` | Configuration of liveness probe | `{}` |
| `readinessProbe` | Configuration of readiness probe | `{}` |
| `resources` | CPU/Memory resource requests/limits | `{}` |
Expand Down
2 changes: 1 addition & 1 deletion charts/verdaccio/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
description: A lightweight private node.js proxy registry
name: verdaccio
version: 4.25.1
version: 4.26.0
appVersion: 6.0.4
home: https://verdaccio.org
icon: https://cdn.verdaccio.dev/logos/default.png
Expand Down
6 changes: 5 additions & 1 deletion charts/verdaccio/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ spec:
matchLabels:
{{- include "verdaccio.selectorLabels" . | nindent 6 }}
strategy:
{{- if .Values.persistence.enabled }}
{{- if .Values.strategy }}
{{- with .Values.strategy }}
{{- toYaml . | nindent 4}}
{{- end }}
{{- else if .Values.persistence.enabled }}
type: Recreate
rollingUpdate: null
{{- else }}
Expand Down
2 changes: 2 additions & 0 deletions charts/verdaccio/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ replicaCount: 1

revisionHistoryLimit: 10

strategy: {}

## Define Probes
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes
livenessProbe: {}
Expand Down
Loading