Allow keeping the data volume #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfiehe
force-pushed
the
add_annotations_pvc
branch
from
5d104fd to
7defac6
Compare
|
Looks good but you need to bump up the version manually |
This commit makes it possible to add custom annotations to the PVC and introduces a new property that allows keeping the data volume on a Helm uninstall operation. Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
cfiehe
force-pushed
the
add_annotations_pvc
branch
from
7defac6 to
fc2d311
Compare
Ah, sorry. I have incremented the chart version number. |
juanpicado
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it possible to add custom annotations to the PVC and introduces a new property that allows keeping the data volume on a Helm uninstall operation.