-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make "resolve" external, fixes pnp #165
Conversation
@guybedford could you please check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you add a test to make sure this works as you expect?
I would need to add new github check, create a dir with yarn3 project, ran yarn install. Is it ok? |
Also would need to pack plugin to tar file. And reference it from yarn3 package. Not straightforward. |
I think it’s best to add a test. Otherwise how do we know it works? And how do we prevent regressions in the future? Imagine bumping the dependency version. |
@styfle added, please approve a run |
Thanks! Looks like windows is failing CI |
I've made it run only on linux, please reapprove. Failing probably because of bash scripts |
Probably because env vars work differently on Windows. Running on linux only is a fine workaround, thanks! |
🎉 This PR is included in version 1.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@goloveychuk I had to disable this test when upgrading dependencies here: |
fixes #163