Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfe): remove hyphen from microfrontends binary name #9683

Merged

Conversation

mknichel
Copy link
Member

@mknichel mknichel commented Jan 10, 2025

Description

The standard naming for microfrontends does not have a hyphen. This updates Turborepo to look for the binary without the hyphen.

Testing Instructions

@mknichel mknichel requested a review from a team as a code owner January 10, 2025 19:23
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Jan 10, 2025
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:23pm

@tknickman tknickman changed the title [Microfrontends] Remove hyphen from microfrontends binary name" feat(mfe): remove hyphen from microfrontends binary name Jan 10, 2025
@mknichel mknichel enabled auto-merge (squash) January 10, 2025 19:28
@mknichel mknichel merged commit 6b4c82d into main Jan 10, 2025
35 of 37 checks passed
@mknichel mknichel deleted the mknichel/microfrontends-remove-hyphen-from-binary-name branch January 10, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants