smarter logical combination that keeps truthy/falsy/nullish property #8873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
Which cases were handled before this PR? |
| Alternatives { | ||
| total_nodes: usize, | ||
| values: Vec<JsValue>, | ||
| additional_property: Option<AdditionalProperty>, |
There was a problem hiding this comment.
Maybe we could store the logical operation here instead, and evaluate on demand? 🤔
I guess that is ever so slightly less optimized
The |
sokra
force-pushed
the
sokra/logical-evaluation
branch
from
585b336
to
b2cc4c2
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arlyon
reviewed
Jul 31, 2024
sokra
force-pushed
the
sokra/logical-evaluation
branch
from
b2cc4c2
to
8a4ede8
Compare
ForsakenHarmony
approved these changes
Jul 31, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 31, 2024
…ercel/turborepo#8873) ### Description Allows to handle `if (unknown && falsy)` `if (unknown || truthy)` `if (unknown ?? nullish)` in static analysis. Hint: review each commit on it's own, since the first commit is only changing to a named struct. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
* vercel/turborepo#8879 <!-- Niklas Mischkulnig - Convert MDX errors into issues --> * vercel/turborepo#8873 <!-- Tobias Koppers - smarter logical combination that keeps truthy/falsy/nullish property --> * vercel/turborepo#8890 <!-- Tobias Koppers - Skip unreachable code when early return can be statically analysed -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…ercel/turborepo#8873) ### Description Allows to handle `if (unknown && falsy)` `if (unknown || truthy)` `if (unknown ?? nullish)` in static analysis. Hint: review each commit on it's own, since the first commit is only changing to a named struct. ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8879 <!-- Niklas Mischkulnig - Convert MDX errors into issues --> * vercel/turborepo#8873 <!-- Tobias Koppers - smarter logical combination that keeps truthy/falsy/nullish property --> * vercel/turborepo#8890 <!-- Tobias Koppers - Skip unreachable code when early return can be statically analysed -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to handle
if (unknown && falsy)if (unknown || truthy)if (unknown ?? nullish)in static analysis.Hint: review each commit on it's own, since the first commit is only changing to a named struct.
Testing Instructions