change from failsafe_analyse to failsafe_parse #8828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and can be snapshot easily
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
This was referenced Jul 24, 2024
sokra
changed the title
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
arlyon
approved these changes
Jul 24, 2024
| @@ -45,6 +45,7 @@ use crate::{ | |||
| #[turbo_tasks::value(shared, serialization = "none", eq = "manual")] | |||
| #[allow(clippy::large_enum_variant)] | |||
| pub enum ParseResult { | |||
| // Note: Ok must not contain any Vc as it's snapshot by failsafe_parse | |||
There was a problem hiding this comment.
Would be nice if we could write our own lints for this...
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description change from failsafe_analyse to failsafe_parse as ParseResult is flat and can be snapshot easily failsafe_analyze didn't work correctly as it stores nested Vcs in State which breaks GC and dropping of excessive cells since these Vcs point to stale cells that no longer exist ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description change from failsafe_analyse to failsafe_parse as ParseResult is flat and can be snapshot easily failsafe_analyze didn't work correctly as it stores nested Vcs in State which breaks GC and dropping of excessive cells since these Vcs point to stale cells that no longer exist ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description change from failsafe_analyse to failsafe_parse as ParseResult is flat and can be snapshot easily failsafe_analyze didn't work correctly as it stores nested Vcs in State which breaks GC and dropping of excessive cells since these Vcs point to stale cells that no longer exist ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description change from failsafe_analyse to failsafe_parse as ParseResult is flat and can be snapshot easily failsafe_analyze didn't work correctly as it stores nested Vcs in State which breaks GC and dropping of excessive cells since these Vcs point to stale cells that no longer exist ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change from failsafe_analyse to failsafe_parse as ParseResult is flat and can be snapshot easily
failsafe_analyze didn't work correctly as it stores nested Vcs in State which breaks GC and dropping of excessive cells since these Vcs point to stale cells that no longer exist
Testing Instructions