fix(sourcemap): update sourcemap, remove checker #7823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
Logs
See job summary for details |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
kwonoj
force-pushed
the
test-update-sourcemap
branch
from
20cc8e3
to
c369272
Compare
🟢 CI successful 🟢Thanks |
wbinnssmith
approved these changes
Mar 23, 2024
kwonoj
force-pushed
the
test-update-sourcemap
branch
from
c369272
to
05dad23
Compare
sokra
reviewed
Mar 23, 2024
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Mar 25, 2024
# Turbopack * vercel/turborepo#7815 <!-- Tobias Koppers - fix alias in getResolve --> * vercel/turborepo#7796 <!-- Donny/강동윤 - Update `swc_core` to `v0.90.24` --> * vercel/turborepo#7775 <!-- Tobias Koppers - fix single css chunks with import context --> * vercel/turborepo#7776 <!-- Tobias Koppers - change port of trace-server --> * vercel/turborepo#7763 <!-- Tobias Koppers - Tracing improvements --> * vercel/turborepo#7813 <!-- Tobias Koppers - fix webpack loader incorrectly calling custom_evaluate --> * vercel/turborepo#7764 <!-- Tobias Koppers - fix some small bugs in turbo-tasks that are required for GC --> * vercel/turborepo#7816 <!-- Chris Olszewski - chore: remove some unused imports --> * vercel/turborepo#7823 <!-- OJ Kwon - fix(sourcemap): update sourcemap, remove checker --> ### What? Update SWC crates to swc-project/swc@ad932f0 ### Why? To keep in sync. ### How? - Closes PACK-2807 - Closes PACK-2819 --------- Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description While debugging https://vercel.slack.com/archives/C03EWR7LGEN/p1711146825831219?thread_ts=1711143217.892349&cid=C03EWR7LGEN, found out sourcemap lookup fails on certain source and always returns synthetictoken only. Weirdly, the guards in this PR https://github.com/vercel/turbo/pull/7823/files#diff-2ce67e28c5b3144ec6f7a89167f3c96da9f9e268abf3fd685ce881d75a4cd8a5L319 is preventing those lookup - removing it makes correct sourcemap lookup occurs. I updated pkg to the version what swc uses and removed + ran next.js tests, seems like most of tests are running just fine (#63624) Still not 100% sure if this'll be ok or not, if not open to change for the correct fixes. Some related fixes getsentry/rust-sourcemap#60 might be the reason we don't see any regressions in the test.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description While debugging https://vercel.slack.com/archives/C03EWR7LGEN/p1711146825831219?thread_ts=1711143217.892349&cid=C03EWR7LGEN, found out sourcemap lookup fails on certain source and always returns synthetictoken only. Weirdly, the guards in this PR https://github.com/vercel/turbo/pull/7823/files#diff-2ce67e28c5b3144ec6f7a89167f3c96da9f9e268abf3fd685ce881d75a4cd8a5L319 is preventing those lookup - removing it makes correct sourcemap lookup occurs. I updated pkg to the version what swc uses and removed + ran next.js tests, seems like most of tests are running just fine (#63624) Still not 100% sure if this'll be ok or not, if not open to change for the correct fixes. Some related fixes getsentry/rust-sourcemap#60 might be the reason we don't see any regressions in the test.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description While debugging https://vercel.slack.com/archives/C03EWR7LGEN/p1711146825831219?thread_ts=1711143217.892349&cid=C03EWR7LGEN, found out sourcemap lookup fails on certain source and always returns synthetictoken only. Weirdly, the guards in this PR https://github.com/vercel/turbo/pull/7823/files#diff-2ce67e28c5b3144ec6f7a89167f3c96da9f9e268abf3fd685ce881d75a4cd8a5L319 is preventing those lookup - removing it makes correct sourcemap lookup occurs. I updated pkg to the version what swc uses and removed + ran next.js tests, seems like most of tests are running just fine (#63624) Still not 100% sure if this'll be ok or not, if not open to change for the correct fixes. Some related fixes getsentry/rust-sourcemap#60 might be the reason we don't see any regressions in the test.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description While debugging https://vercel.slack.com/archives/C03EWR7LGEN/p1711146825831219?thread_ts=1711143217.892349&cid=C03EWR7LGEN, found out sourcemap lookup fails on certain source and always returns synthetictoken only. Weirdly, the guards in this PR https://github.com/vercel/turbo/pull/7823/files#diff-2ce67e28c5b3144ec6f7a89167f3c96da9f9e268abf3fd685ce881d75a4cd8a5L319 is preventing those lookup - removing it makes correct sourcemap lookup occurs. I updated pkg to the version what swc uses and removed + ran next.js tests, seems like most of tests are running just fine (#63624) Still not 100% sure if this'll be ok or not, if not open to change for the correct fixes. Some related fixes getsentry/rust-sourcemap#60 might be the reason we don't see any regressions in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While debugging https://vercel.slack.com/archives/C03EWR7LGEN/p1711146825831219?thread_ts=1711143217.892349&cid=C03EWR7LGEN, found out sourcemap lookup fails on certain source and always returns synthetictoken only.
Weirdly, the guards in this PR https://github.com/vercel/turbo/pull/7823/files#diff-2ce67e28c5b3144ec6f7a89167f3c96da9f9e268abf3fd685ce881d75a4cd8a5L319 is preventing those lookup - removing it makes correct sourcemap lookup occurs. I updated pkg to the version what swc uses and removed + ran next.js tests, seems like most of tests are running just fine
(vercel/next.js#63624)
Still not 100% sure if this'll be ok or not, if not open to change for the correct fixes. Some related fixes getsentry/rust-sourcemap#60 might be the reason we don't see any regressions in the test.