fix externals in side-effect optimized modules #7797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
Logs
See job summary for details |
timneutkens
approved these changes
Mar 22, 2024
kdy1
approved these changes
Mar 25, 2024
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 27, 2024
* vercel/turborepo#7797 <!-- Tobias Koppers - fix externals in side-effect optimized modules --> * vercel/turborepo#7830 <!-- Tobias Koppers - Avoid showing import map description in resolving issue when there is no import map mapping --> * vercel/turborepo#7833 <!-- Tobias Koppers - add next.js trace format --> * vercel/turborepo#7835 <!-- Tobias Koppers - correct global start by first start time --> * vercel/turborepo#7812 <!-- Will Binns-Smith - Turbopack docs: Fix broken webpack loaders link --> * vercel/turborepo#7847 <!-- Will Binns-Smith - Turbo tasks: Reuse aggregation context and apply queued updates --> * vercel/turborepo#7840 <!-- Tobias Koppers - add concurrency corrected duration --> * vercel/turborepo#7854 <!-- Tobias Koppers - fix size_hint on count hash set -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description fixes a problem where an async module wrapper is generated for external modules in a "locals" module part when there is usage of the external module in the locals part fixes #63485 ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2810 fixes PACK-2805
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description fixes a problem where an async module wrapper is generated for external modules in a "locals" module part when there is usage of the external module in the locals part fixes #63485 ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2810 fixes PACK-2805
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description fixes a problem where an async module wrapper is generated for external modules in a "locals" module part when there is usage of the external module in the locals part fixes #63485 ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2810 fixes PACK-2805
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description fixes a problem where an async module wrapper is generated for external modules in a "locals" module part when there is usage of the external module in the locals part fixes #63485 ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2810 fixes PACK-2805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes a problem where an async module wrapper is generated for external modules in a "locals" module part when there is usage of the external module in the locals part
fixes vercel/next.js#63485
Testing Instructions
Closes PACK-2810
fixes PACK-2805