make follow reexports more efficient #7741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
kdy1
approved these changes
Mar 18, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description When accessing many exports of a barrel file with many `export *` it was a bit inefficient before since it was walking all star exports for every accessed export. After this change it only creates a map of the star exports once and accessing every export only looks up the result in the map. This makes it 4 times more efficient for a file with 140 `export *`. Probably even more for bigger barrel files. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2747
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description When accessing many exports of a barrel file with many `export *` it was a bit inefficient before since it was walking all star exports for every accessed export. After this change it only creates a map of the star exports once and accessing every export only looks up the result in the map. This makes it 4 times more efficient for a file with 140 `export *`. Probably even more for bigger barrel files. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2747
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description When accessing many exports of a barrel file with many `export *` it was a bit inefficient before since it was walking all star exports for every accessed export. After this change it only creates a map of the star exports once and accessing every export only looks up the result in the map. This makes it 4 times more efficient for a file with 140 `export *`. Probably even more for bigger barrel files. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2747
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description When accessing many exports of a barrel file with many `export *` it was a bit inefficient before since it was walking all star exports for every accessed export. After this change it only creates a map of the star exports once and accessing every export only looks up the result in the map. This makes it 4 times more efficient for a file with 140 `export *`. Probably even more for bigger barrel files. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When accessing many exports of a barrel file with many
export *it was a bit inefficient before since it was walking all star exports for every accessed export.After this change it only creates a map of the star exports once and accessing every export only looks up the result in the map. This makes it 4 times more efficient for a file with 140
export *. Probably even more for bigger barrel files.Testing Instructions
Closes PACK-2747