Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): Do not resolve urls in supports query #7730

Merged
merged 7 commits into from
Mar 14, 2024
Merged

fix(css): Do not resolve urls in supports query #7730

merged 7 commits into from
Mar 14, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 14, 2024 •
edited
Loading

Description

Testing Instructions

I added a test.

@kdy1 kdy1 self-assigned this Mar 14, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 8:58am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 8:58am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 8:58am
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:58am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:58am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:58am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:58am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:58am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:58am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:58am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@kdy1
Copy link
Member Author

kdy1 commented Mar 14, 2024

It seems like we don't resolve urls in turbopack-tests anyway

@kdy1 kdy1 marked this pull request as ready for review March 14, 2024 03:59
@kdy1 kdy1 requested a review from a team as a code owner March 14, 2024 03:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=2d586f8fc468383181d9c288838cce923c36b6fa#85545db0)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.90.22` are: 0.90.22

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.90.21`
    ... which satisfies dependency `swc_core = "^0.90.21"` (locked to 0.90.21) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 kdy1 marked this pull request as draft March 14, 2024 08:03
@kdy1 kdy1 marked this pull request as ready for review March 14, 2024 08:49
@sokra sokra merged commit 8359016 into main Mar 14, 2024
47 of 50 checks passed
@sokra sokra deleted the kdy1/pack-2717 branch March 14, 2024 11:50
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kdy1
fix(css): Do not resolve urls in supports query (vercel/turborepo#7730
8f7f5f4 
)

### Description

 - Closes #63102
 - Closes PACK-2717


### Testing Instructions

I added a test.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1
fix(css): Do not resolve urls in supports query (vercel/turborepo#7730
2b6c6a0 
)

### Description

 - Closes #63102
 - Closes PACK-2717


### Testing Instructions

I added a test.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1
fix(css): Do not resolve urls in supports query (vercel/turborepo#7730
e8a8c96 
)

### Description

 - Closes #63102
 - Closes PACK-2717


### Testing Instructions

I added a test.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kdy1
fix(css): Do not resolve urls in supports query (vercel/turborepo#7730
bdd58b8 
)

### Description

 - Closes #63102
 - Closes PACK-2717


### Testing Instructions

I added a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees

@kdy1 kdy1

Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turbopack: Can't resolve url in pre-compiled CSS
2 participants
@kdy1 @sokra