more efficient node.js process startup #7661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
Logs
See job summary for details |
|
kdy1
reviewed
Mar 12, 2024
| let expected_completed_task_until_full_workers = { | ||
| let millis = max(1, warm_process_time.as_millis()); | ||
| let ready_workers = workers - booting_workers; | ||
| (expected_full_workers_in.as_millis() / millis) as u32 * ready_workers |
There was a problem hiding this comment.
Isn't it better to multiply first before dividing? (Not important as the numbers are millis, which are not very small)
kdy1
approved these changes
Mar 13, 2024
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2024
# Turbopack * vercel/turborepo#7719 <!-- Tobias Koppers - accept css files outside of the project as virtual assets --> * vercel/turborepo#7661 <!-- Tobias Koppers - more efficient node.js process startup --> * vercel/turborepo#7720 <!-- Tobias Koppers - generate correct async module handling for side effects optimization --> * vercel/turborepo#7718 <!-- Donny/강동윤 - fix(turbopack): Fix CSS Modules class name for lightningcss mode --> ### What? Update tests to make CSS Modules of `lightningcss` work with CSS grids. ### Why? `lightningcss` enforces the class name to end with `[local]`. See: https://lightningcss.dev/css-modules.html#css-grid ### How? Closes PACK-2731
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description * Slow start for the concurrency of parallel booting node.js processes (1, 2, 4, ...) * Depending on historic statistics avoid booting up a new process, but wait for one to finish computing Loading the `/home` route on 16-core machine Before: ``` 16 x Node.js process startup 9.09s avg 568.07ms 16 x Node.js initialization 10.58s avg 660.96ms 276 x Node.js evaluation 30.17s avg 109.30ms ``` After: ``` 7 x Node.js process startup 1261.79ms avg 180.26ms 7 x Node.js initialization 3.15s avg 450.21ms 276 x Node.js evaluation 29.41s avg 106.55ms ``` ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2680
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * Slow start for the concurrency of parallel booting node.js processes (1, 2, 4, ...) * Depending on historic statistics avoid booting up a new process, but wait for one to finish computing Loading the `/home` route on 16-core machine Before: ``` 16 x Node.js process startup 9.09s avg 568.07ms 16 x Node.js initialization 10.58s avg 660.96ms 276 x Node.js evaluation 30.17s avg 109.30ms ``` After: ``` 7 x Node.js process startup 1261.79ms avg 180.26ms 7 x Node.js initialization 3.15s avg 450.21ms 276 x Node.js evaluation 29.41s avg 106.55ms ``` ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2680
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * Slow start for the concurrency of parallel booting node.js processes (1, 2, 4, ...) * Depending on historic statistics avoid booting up a new process, but wait for one to finish computing Loading the `/home` route on 16-core machine Before: ``` 16 x Node.js process startup 9.09s avg 568.07ms 16 x Node.js initialization 10.58s avg 660.96ms 276 x Node.js evaluation 30.17s avg 109.30ms ``` After: ``` 7 x Node.js process startup 1261.79ms avg 180.26ms 7 x Node.js initialization 3.15s avg 450.21ms 276 x Node.js evaluation 29.41s avg 106.55ms ``` ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2680
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description * Slow start for the concurrency of parallel booting node.js processes (1, 2, 4, ...) * Depending on historic statistics avoid booting up a new process, but wait for one to finish computing Loading the `/home` route on 16-core machine Before: ``` 16 x Node.js process startup 9.09s avg 568.07ms 16 x Node.js initialization 10.58s avg 660.96ms 276 x Node.js evaluation 30.17s avg 109.30ms ``` After: ``` 7 x Node.js process startup 1261.79ms avg 180.26ms 7 x Node.js initialization 3.15s avg 450.21ms 276 x Node.js evaluation 29.41s avg 106.55ms ``` ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loading the
/homeroute on 16-core machineBefore:
After:
Testing Instructions
Closes PACK-2680