-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include expanded inputs config for each task in dry run summary #3957
Merged
mehulkar
merged 11 commits into
main
from
mehulkar/turbo-836-add-expanded-inputs-to-each-task-summary
Feb 28, 2023
Merged
Include expanded inputs config for each task in dry run summary #3957
mehulkar
merged 11 commits into
main
from
mehulkar/turbo-836-add-expanded-inputs-to-each-task-summary
Feb 28, 2023
Commits on Feb 25, 2023
-
Move WorkspaceInfos to its own package
The taskhash package imports the graph package to use this type. In a future commit, I need to make the graph package also import the taskhash package. This will cause an import cycle. Pulling this struct out into its own package will take me one step closer to being able to remove the graph import from the taskhash package. I had to also rename the struct from WorkspaceInfos to something else (I chose Catalog), because golangci-lint warns (which fails our CI) that workspace.WorkspaceInfo can be an "annoying" name.
Configuration menu - View commit details
-
Copy full SHA for b7324b6 - Browse repository at this point
Copy the full SHA b7324b6View commit details -
Call it a taskHashTracker consistently everywhere
This is an aesthetic change. I was having trouble reading a reference to this struct and package with different names everywhere, so I'm renaming it all to the same name.
Configuration menu - View commit details
-
Copy full SHA for 66560e6 - Browse repository at this point
Copy the full SHA 66560e6View commit details -
Don't pass in graph to TaskHashTracker
This finishes the swing for removing the graph import in the taskhash package. As mentioned in b7324b6, this will allow me to do the inverse: to import the taskhash package into the graph package.
Configuration menu - View commit details
-
Copy full SHA for 5b010ce - Browse repository at this point
Copy the full SHA 5b010ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for aeadc71 - Browse repository at this point
Copy the full SHA aeadc71View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1e51e5 - Browse repository at this point
Copy the full SHA d1e51e5View commit details -
Add ExpandedInputs to Dry Run Summary
Give the CompleteGraph struct access to the TaskHashTracker instance so we can use it while constructing PackageTasks. PackageTasks are then available when walking the graph during dry run execution, and we can add them into the Dry Run output. This approach also makes it trivial to use the PackageTask.ExpandedInputs during RealRun execution so we can print them as debug output in a Run Summary
Configuration menu - View commit details
-
Copy full SHA for 6fb0796 - Browse repository at this point
Copy the full SHA 6fb0796View commit details
Commits on Feb 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9e64ae0 - Browse repository at this point
Copy the full SHA 9e64ae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d317727 - Browse repository at this point
Copy the full SHA d317727View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f9c126 - Browse repository at this point
Copy the full SHA 8f9c126View commit details -
Configuration menu - View commit details
-
Copy full SHA for c724a9a - Browse repository at this point
Copy the full SHA c724a9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98a1782 - Browse repository at this point
Copy the full SHA 98a1782View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.