Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include expanded inputs config for each task in dry run summary #3957

Merged

Commits on Feb 25, 2023

  1. Move WorkspaceInfos to its own package

    The taskhash package imports the graph package to use this type. In a
    future commit, I need to make the graph package also import the taskhash
    package. This will cause an import cycle. Pulling this struct out into
    its own package will take me one step closer to being able to remove the
    graph import from the taskhash package.
    
    I had to also rename the struct from WorkspaceInfos to something else (I
    chose Catalog), because golangci-lint warns (which fails our CI) that
    workspace.WorkspaceInfo can be an "annoying" name.
    mehulkar committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    b7324b6 View commit details
    Browse the repository at this point in the history
  2. Call it a taskHashTracker consistently everywhere

    This is an aesthetic change. I was having trouble reading a reference to
    this struct and package with different names everywhere, so I'm renaming
    it all to the same name.
    mehulkar committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    66560e6 View commit details
    Browse the repository at this point in the history
  3. Don't pass in graph to TaskHashTracker

    This finishes the swing for removing the graph import in the taskhash
    package. As mentioned in b7324b6, this will allow me to do the
    inverse: to import the taskhash package into the graph package.
    mehulkar committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    5b010ce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aeadc71 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1e51e5 View commit details
    Browse the repository at this point in the history
  6. Add ExpandedInputs to Dry Run Summary

    Give the CompleteGraph struct access to the TaskHashTracker instance
    so we can use it while constructing PackageTasks. PackageTasks are
    then available when walking the graph during dry run execution, and
    we can add them into the Dry Run output. This approach also makes it
    trivial to use the PackageTask.ExpandedInputs during RealRun execution
    so we can print them as debug output in a Run Summary
    mehulkar committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    6fb0796 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Configuration menu
    Copy the full SHA
    9e64ae0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d317727 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8f9c126 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c724a9a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    98a1782 View commit details
    Browse the repository at this point in the history