Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messaging when using nonexistent task name #3902

Closed
wants to merge 1 commit into from

Conversation

mehulkar
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 0:38AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:38AM (UTC)

for _, taskName := range taskNames {
// look for task name in all workspaces and exit if it isn't found?
fmt.Printf("[debug] taskName %#v\n", taskName)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like a great idea to load all configs just to validate that a task name is valid, even though we know we're not going to execute it. Is there any reason to implement this?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Go integration tests

See workflow summary for details

Base automatically changed from mehulkar/turbo-824-error-with---filter-option to main February 22, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant