Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split swc_core/allocator_node out of __swc_core_binding_napi #3772

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Split swc_core/allocator_node out of __swc_core_binding_napi #3772

merged 2 commits into from
Feb 14, 2023

Conversation

Brooooooklyn
Copy link
Contributor

We only can use turbo_malloc in next.js without swc_node_base included

@Brooooooklyn Brooooooklyn requested a review from a team as a code owner February 13, 2023 16:20
@vercel
Copy link

vercel bot commented Feb 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-kitchensink-blog 🔄 Building (Inspect) Feb 14, 2023 at 3:03AM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 3:03AM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:03AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:03AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:03AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:03AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:03AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:03AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:03AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 3:03AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

This was referenced Feb 13, 2023
Merged
Merged
@github-actions
Copy link
Contributor

Benchmark for f0c0f13

Test Base PR % Significant %
bench_hydration/Turbopack RCC/1000 modules 4329.87ms ± 21.70ms 4264.18ms ± 9.84ms -1.52% -0.06%
bench_hydration/Turbopack SSR/1000 modules 3762.37ms ± 5.77ms 3727.28ms ± 10.82ms -0.93% -0.05%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9472.28µs ± 94.84µs 9282.66µs ± 164.67µs -2.00%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.55ms ± 0.26ms 12.93ms ± 0.28ms +3.03%
bench_hmr_to_commit/Turbopack RSC/1000 modules 509.37ms ± 2.71ms 508.49ms ± 1.91ms -0.17%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9534.82µs ± 93.06µs 9699.36µs ± 126.33µs +1.73%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8500.04µs ± 127.80µs 8501.01µs ± 114.99µs +0.01%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.24ms ± 0.33ms 10.95ms ± 0.14ms -2.61%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8471.46µs ± 107.23µs 8588.23µs ± 93.35µs +1.38%
bench_hydration/Turbopack RCC/1000 modules 4329.87ms ± 21.70ms 4264.18ms ± 9.84ms -1.52% -0.06%
bench_hydration/Turbopack RSC/1000 modules 3830.84ms ± 15.48ms 3847.62ms ± 17.53ms +0.44%
bench_hydration/Turbopack SSR/1000 modules 3762.37ms ± 5.77ms 3727.28ms ± 10.82ms -0.93% -0.05%
bench_startup/Turbopack CSR/1000 modules 2807.66ms ± 9.02ms 2814.56ms ± 15.26ms +0.25%
bench_startup/Turbopack RCC/1000 modules 2562.05ms ± 5.12ms 2576.04ms ± 5.00ms +0.55%
bench_startup/Turbopack RSC/1000 modules 2490.09ms ± 8.75ms 2481.86ms ± 8.79ms -0.33%
bench_startup/Turbopack SSR/1000 modules 2125.29ms ± 1.98ms 2117.82ms ± 2.25ms -0.35%

@Brooooooklyn Brooooooklyn added pr: automerge Kodiak will merge these automatically after checks pass and removed pr: automerge Kodiak will merge these automatically after checks pass labels Feb 14, 2023
Brooooooklyn added a commit to swc-project/swc that referenced this pull request Feb 14, 2023
@Brooooooklyn
chore(swc_nodejs_common): remove swc_node_base from swc_nodejs_common (…
0771418 
…#6940)

- Ref: vercel/turborepo#3772
@Brooooooklyn Brooooooklyn added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 14, 2023
@kodiakhq kodiakhq bot merged commit 3fbb505 into main Feb 14, 2023
@kodiakhq kodiakhq bot deleted the split-allocator-out branch February 14, 2023 03:23
@github-actions
Copy link
Contributor

Benchmark for 889e86f

Test Base PR % Significant %
bench_startup/Turbopack SSR/1000 modules 2184.47ms ± 5.00ms 2164.49ms ± 3.14ms -0.91% -0.17%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.08ms ± 0.07ms 10.16ms ± 0.09ms +0.77%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.57ms ± 0.17ms 12.24ms ± 0.15ms -2.60%
bench_hmr_to_commit/Turbopack RSC/1000 modules 525.95ms ± 2.69ms 522.57ms ± 3.08ms -0.64%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.26ms ± 0.08ms 10.23ms ± 0.06ms -0.29%
bench_hmr_to_eval/Turbopack CSR/1000 modules 9052.79µs ± 56.51µs 9091.75µs ± 85.00µs +0.43%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.22ms ± 0.19ms 10.96ms ± 0.20ms -2.29%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9125.97µs ± 92.84µs 9128.51µs ± 66.57µs +0.03%
bench_hydration/Turbopack RCC/1000 modules 4304.36ms ± 12.38ms 4308.33ms ± 9.97ms +0.09%
bench_hydration/Turbopack RSC/1000 modules 3888.98ms ± 16.53ms 3894.26ms ± 13.67ms +0.14%
bench_hydration/Turbopack SSR/1000 modules 3774.67ms ± 16.43ms 3779.75ms ± 14.45ms +0.13%
bench_startup/Turbopack CSR/1000 modules 2840.86ms ± 8.04ms 2848.11ms ± 13.56ms +0.26%
bench_startup/Turbopack RCC/1000 modules 2625.66ms ± 6.91ms 2620.66ms ± 8.53ms -0.19%
bench_startup/Turbopack RSC/1000 modules 2514.05ms ± 9.19ms 2535.86ms ± 9.37ms +0.87%
bench_startup/Turbopack SSR/1000 modules 2184.47ms ± 5.00ms 2164.49ms ± 3.14ms -0.91% -0.17%

timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 14, 2023
@Brooooooklyn
Upgrade turbopack (#45861)
e3843c9 
The `experimental.turbotrace.memoryLimit` is not actually working, we
need to use `turbo_malloc` as the global allocator to make it work.

~~Block by:~~
- swc-project/swc#6940
- vercel/turborepo#3772

## This PR also upgrades `turbopack-230213.2` to `turbopack-230214.1`

- vercel/turborepo#3767
- vercel/turborepo#3772
- vercel/turborepo#3762
- vercel/turborepo#3741
- vercel/turborepo#3796
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@Brooooooklyn
Split swc_core/allocator_node out of __swc_core_binding_napi (vercel/…
43189ee 
…turborepo#3772)

We only can use `turbo_malloc`  in `next.js` without `swc_node_base` included
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@Brooooooklyn
Split swc_core/allocator_node out of __swc_core_binding_napi (vercel/…
ca14667 
…turborepo#3772)

We only can use `turbo_malloc`  in `next.js` without `swc_node_base` included
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@Brooooooklyn
Split swc_core/allocator_node out of __swc_core_binding_napi (vercel/…
6db0108 
…turborepo#3772)

We only can use `turbo_malloc`  in `next.js` without `swc_node_base` included
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@Brooooooklyn
Split swc_core/allocator_node out of __swc_core_binding_napi (vercel/…
6d9abad 
…turborepo#3772)

We only can use `turbo_malloc`  in `next.js` without `swc_node_base` included
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@Brooooooklyn
Split swc_core/allocator_node out of __swc_core_binding_napi (vercel/…
4df8e4f 
…turborepo#3772)

We only can use `turbo_malloc`  in `next.js` without `swc_node_base` included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brooooooklyn @sokra