Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite project entirely #374

Merged
merged 25 commits into from
May 28, 2018
Merged

Rewrite project entirely #374

merged 25 commits into from
May 28, 2018

Conversation

leo
Copy link
Contributor

@leo leo commented May 25, 2018

This PR introduces serve-handler as the core of serve.

This is removing several command line flags (which were bloating the project), but also adding support for many more configuration options.

As a result, it makes serve more powerful, faster and more lean than ever before.


NOTE: This is a fresh start. As mentioned above, a lot of features have been removed for which we couldn't find any reason to keep them as part of the core.

Once this is out, we'll re-evaluate every suggestion and see whether it makes sense to include it in serve itself, or if it makes more sense to just drop serve-handler into a 3-line .js file with micro in it and then add another middleware for the feature that you're looking for.

@leo leo changed the title Rewrite Rewrite project entirely May 25, 2018
@vercel vercel deleted a comment from vercel bot May 28, 2018
@leo leo requested a review from timneutkens May 28, 2018 12:04
@vercel vercel deleted a comment from vercel bot May 28, 2018
@vercel vercel deleted a comment from vercel bot May 28, 2018
@vercel
Copy link

vercel bot commented May 28, 2018

Changes in this PR will be automatically deployed with Now.

This message will be updated over time.

@leo leo merged commit 395830d into master May 28, 2018
@leo leo deleted the rewrite branch May 28, 2018 17:05
@dawsbot
Copy link

dawsbot commented May 29, 2018

I can hear the servers worldwide crying:

We should have pinned our major 😢

Our company has something like 20 separate frontend apps that all broke on this merge. Time to go fix them 1-by-1. Perhaps there's an announcement system to the create-react-app ecosystem on a change like this before it's done?

For reference, our command which now fails was "serve -s -t -p 5000 .". This is now met with "ERROR: Unknown or unexpected option: -t".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants