Allow custom headers to be set for default error responses #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo
commented
Jul 5, 2018
| @@ -501,7 +510,7 @@ module.exports = async (request, response, config = {}, methods = {}) => { | |||
| try { | |||
| relativePath = decodeURIComponent(url.parse(request.url).pathname); | |||
| } catch (err) { | |||
| return sendError(response, acceptsJSON, current, handlers, config, { | |||
| return sendError('/', response, acceptsJSON, current, handlers, config, { | |||
There was a problem hiding this comment.
The absolutePath is not defined here yet, so we need to supply a placeholder.
OlliV
reviewed
Jul 5, 2018
| type: 'inline' | ||
| }) | ||
| }; | ||
| let defaultHeaders = {}; |
There was a problem hiding this comment.
you could also destructure to the existing const variable but that's a bit ugly 🤷♂️
src/index.js
Outdated
| response.setHeader('Content-Type', 'text/html; charset=utf-8'); | ||
| const headers = await getHeaders(config.headers, current, absolutePath, null); | ||
|
|
||
| response.writeHead(statusCode, Object.assign(headers, { |
There was a problem hiding this comment.
Why assign? You are modifying the headers anyway if you do this. Do you want to modify the original object?
Perhaps you want to do:
Object.assign({}, headers, {...})
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 281 285 +4
=====================================
+ Hits 281 285 +4
Continue to review full report at Codecov.
|
OlliV
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, custom headers were not applied to all error responses, only for
.htmlpages.Once this is merged, they will also be applied to the default error renderings.