Reduce number of stat calls #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 254 271 +17
=====================================
+ Hits 254 271 +17
Continue to review full report at Codecov.
|
OlliV
approved these changes
Jun 6, 2018
rauchg
reviewed
Jun 6, 2018
src/index.js
Outdated
| response.end(err.message); | ||
| // It's extremely important that we're doing multiple stat calls. This one | ||
| // right here could technically be removed, but then the program | ||
| // would be slower. Cause for directories, we always wanna see if a related file |
There was a problem hiding this comment.
Nit: Proper English would be nice for code comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the package was firstly checking the existence of the requested path and then seeing if related paths like
<path>/index.htmlexist.However, since directory listings are not the most common use case of this package (but rather rendering files and static projects), I decided to move this further down the line.
As a result, if you request
/, the firststatcall will no more be for the directory/, but rather for/index.html, as long ascleanUrlsor a respectiverewritesitem is enabled.🎉 This is not a breaking change, it only reduces the number of
statcalls to be made until a file is reached and sent back to the client.🍏 I also added 6 more tests, in addition to the existing ones passing. We now have 45!