-
Notifications
You must be signed in to change notification settings - Fork 1k
Add classPrivateMethods plugin to babel parser #1249
Conversation
Fixes vercel#1248 I'd like to be able to pass in my own version of babel parser, configured with my own set of plugins.
This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label |
This pull-request is now closed due to inactivity, you can of course reopen or reference this pull-request if you see fit. |
@leerob what's the story here for people wanting to pitch in? I never got any comments from a maintainer. |
@hcldan Sorry I may have missed this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! |
I would recommend users to transform/transpile their projects first, if novel syntaxes or new JS features are used. pkg supports older Node.js runtime so the built-in parser configuration is rather conservative. This makes sure that you would get an error if you attempt to use features that are only available in newer Node.js runtimes. Note that pkg only uses Babel to walk dependencies. It does not touch your source code.
|
Fixes #1248
I'd like to be able to pass in my own version of babel parser, configured with my own set of plugins.