chore: clean up obsolete eslint disable comments (#1760)

lib/detector.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies
 import * as babelTypes from '@babel/types';
 import * as babel from '@babel/parser';
 import generate from '@babel/generator';
@@ -84,7 +83,6 @@ function reconstruct(node: babelTypes.Node) {
   let v = generate(node, { comments: false }).code.replace(/\n/g, '');
   let v2;
 
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     v2 = v.replace(/\[ /g, '[').replace(/ \]/g, ']').replace(/ {2}/g, ' ');
 
@@ -436,7 +434,6 @@ export function visitorMalformed(n: babelTypes.Node) {
 }
 
 export function visitorUseSCWD(n: babelTypes.Node) {
-  // eslint-disable-line camelcase
   if (!babelTypes.isCallExpression(n)) {
     return null;
   }

lib/index.ts

@@ -219,7 +219,6 @@ async function needViaCache(target: NodeTarget) {
 }
 
 export async function exec(argv2: string[]) {
-  // eslint-disable-line complexity
   const argv = minimist(argv2, {
     boolean: [
       'b',
@@ -294,7 +293,6 @@ export async function exec(argv2: string[]) {
     case 'none':
       break;
     default:
-      // eslint-disable-next-line no-console
       throw wasReported(
         `Invalid compression algorithm ${algo} ( should be None, Brotli or Gzip)`
       );

lib/refiner.ts

@@ -22,7 +22,6 @@ function hasParent(file: string, records: FileRecords) {
 }
 
 function purgeTopDirectories(records: FileRecords) {
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     let found = false;
 

lib/walker.ts

@@ -738,7 +738,6 @@ class Walker {
     marker: Marker,
     derivative: Derivative
   ) {
-    // eslint-disable-line camelcase
     const newPackages: { packageJson: string; marker?: Marker }[] = [];
 
     const catchReadFile = (file: string) => {
@@ -871,7 +870,6 @@ class Walker {
   }
 
   async step_STORE_ANY(record: FileRecord, marker: Marker, store: number) {
-    // eslint-disable-line camelcase
     if (strictVerify) {
       assert(record.file === toNormalizedRealPath(record.file));
     }

prelude/bootstrap.js

@@ -588,7 +588,7 @@ function payloadFileSync(pointer) {
   process.pkg.path.resolve = function resolve() {
     const args = cloneArgs(arguments);
     args.unshift(path.dirname(ENTRYPOINT));
-    return path.resolve.apply(path, args); // eslint-disable-line prefer-spread
+    return path.resolve.apply(path, args);
   };
 })();
 
@@ -722,7 +722,6 @@ function payloadFileSync(pointer) {
     return fName;
   }
 
-  // eslint-disable-next-line prefer-arrow-callback
   const uncompressExternally = function uncompressExternally(dock) {
     if (!dock.externalFilename) {
       const snapshotFilename = dock.path;
@@ -737,7 +736,6 @@ function payloadFileSync(pointer) {
     return dock.externalFilename;
   };
 
-  // eslint-disable-next-line prefer-arrow-callback
   function uncompressExternallyPath(path_) {
     const entity = findVirtualFileSystemEntry(path_);
     const dock = { path: path_, entity, position: 0 };
@@ -750,7 +748,6 @@ function payloadFileSync(pointer) {
     return fd;
   }
 
-  // eslint-disable-next-line prefer-arrow-callback
   function openFromSnapshot(path_, uncompress, cb) {
     const cb2 = cb || rethrow;
     const entity = findVirtualFileSystemEntry(path_);
@@ -1752,7 +1749,6 @@ function payloadFileSync(pointer) {
     return process.binding('fs').internalModuleStat(makeLong(fNative));
   }
 
-  // eslint-disable-next-line prefer-arrow-callback
   fs.internalModuleStat = function internalModuleStat(long) {
     // from node comments:
     // Used to speed up module loading. Returns 0 if the path refers to

test/test-50-ast-parsing-2/test-x-index.js

@@ -18,7 +18,7 @@ require(/**/ async + 75.25 /**/);
 require(/**/ __dirname + '/' + async /**/); // eslint-disable-line no-path-concat
 require(/**/ __dirname + '/' + async + 35.5 /**/); // eslint-disable-line no-path-concat
 
-require(/**/ [async, 'js'].join('.') /**/); // eslint-disable-line array-bracket-spacing
+require(/**/ [async, 'js'].join('.') /**/);
 // TODO require({ async: "js" }.join("."));
 
 require(/**/ async[0] /**/);

test/test-50-global-object/test-y-resolve-A.js

@@ -1,4 +1,4 @@
 'use strict';
 
 global.x = 42;
-console.log(x); // eslint-disable-line no-undef
+console.log(x);

test/test-50-global-object/test-y-resolve-B.js

@@ -1,4 +1,4 @@
 'use strict';
 
 global.y = 84;
-console.log(y); // eslint-disable-line no-undef
+console.log(y);

test/test-50-many-arrow-functions/test-z-creator.js

@@ -1,6 +1,5 @@
 'use strict';
 
-// eslint-disable no-useless-concat
 let s =
   'function EventEmitter () {\n' +
   '  this.listeners = [];\n' +

test/test-50-many-callbacks/test-z-creator.js

@@ -1,7 +1,5 @@
 'use strict';
 
-// eslint-disable no-useless-concat
-
 let s = "console.log('test');\n";
 
 for (let i = 0; i < 100; i += 1) {

test/test-79-npm/mongoose/mongoose.js

@@ -11,7 +11,7 @@ kitty.save(function (error1) {
   if (error1) return;
   Cat.find({})
     .$where(function () {
-      return this.name.slice(0, 3) === 'Tuz'; // eslint-disable-line no-invalid-this
+      return this.name.slice(0, 3) === 'Tuz';
     })
     .exec(function (error2, cats) {
       if (process.pkg) {

test/test-80-compression-various-file-access/test_with_new_fs_promises.js

@@ -24,7 +24,6 @@ async function withPromises() {
     const buffer = Buffer.alloc(1000);
 
     if (MAJOR_VERSION >= 14) {
-      // eslint-disable-line no-unused-vars
       const { bytesRead } = await fd.read(buffer, 0, buffer.length, 10);
       if (process.env.DEBUG) {
         console.log('bytesRead = ', bytesRead);