test: test pnpm packages only on node >= 14.19 (#1613)

vercel · May 5, 2022 · 193b778 · 193b778
1 parent 8cd98af
commit 193b778
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 17 deletions.
diff --git a/test/test-10-pnpm/main.js b/test/test-10-pnpm/main.js
@@ -7,13 +7,7 @@ const path = require('path');
 const assert = require('assert');
 const utils = require('../utils.js');
 
-// ignore this test if nodejs <= 10 , as recent version of PNPM do not support nodejs=10
-const MAJOR_VERSION = parseInt(process.version.match(/v([0-9]+)/)[1], 10);
-if (MAJOR_VERSION < 12) {
-  console.log(
-    'skiping test as it requires nodejs >= 12 and got',
-    MAJOR_VERSION
-  );
+if (utils.shouldSkipPnpm()) {
   return;
 }
 

diff --git a/test/test-11-pnpm/main.js b/test/test-11-pnpm/main.js
@@ -7,13 +7,7 @@ const path = require('path');
 const assert = require('assert');
 const utils = require('../utils.js');
 
-// ignore this test if nodejs <= 10 , as recent version of PNPM do not support nodejs=10
-const MAJOR_VERSION = parseInt(process.version.match(/v([0-9]+)/)[1], 10);
-if (MAJOR_VERSION < 12) {
-  console.log(
-    'skiping test as it requires nodejs >= 12 and got',
-    MAJOR_VERSION
-  );
+if (utils.shouldSkipPnpm()) {
   return;
 }
 

diff --git a/test/test-12-compression-node-opcua/main.js b/test/test-12-compression-node-opcua/main.js
@@ -16,9 +16,7 @@ const utils = require('../utils.js');
 assert(!module.parent);
 assert(__dirname === process.cwd());
 
-// ignore this test if nodejs <= 10 , as recent version of PNPM do not support nodejs=10
-const MAJOR_VERSION = parseInt(process.version.match(/v([0-9]+)/)[1], 10);
-if (MAJOR_VERSION < 12) {
+if (utils.shouldSkipPnpm()) {
   return;
 }
 

diff --git a/test/utils.js b/test/utils.js
@@ -165,3 +165,22 @@ module.exports.filesAfter = function (b, n) {
     module.exports.vacuum.sync(ni);
   }
 };
+
+module.exports.shouldSkipPnpm = function () {
+  const REQUIRED_MAJOR_VERSION = 14;
+  const REQUIRED_MINOR_VERSION = 19;
+
+  const MAJOR_VERSION = parseInt(process.version.match(/v([0-9]+)/)[1], 10);
+  const MINOR_VERSION = parseInt(process.version.match(/v[0-9]+\.([0-9]+)/)[1], 10);
+
+  const isDisallowedMajor = MAJOR_VERSION < REQUIRED_MAJOR_VERSION
+  const isDisallowedMinor = MAJOR_VERSION === REQUIRED_MAJOR_VERSION && MINOR_VERSION < REQUIRED_MINOR_VERSION;
+  if (isDisallowedMajor || isDisallowedMinor) {
+    const need = `${REQUIRED_MAJOR_VERSION}.${REQUIRED_MINOR_VERSION}`;
+    const got = `${MAJOR_VERSION}.${MINOR_VERSION}`;
+    console.log(`skiping test as it requires nodejs >= ${need} and got ${got}`);
+    return true;
+  }
+
+  return false;
+}