Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

patches: bump to 19.8.1 #284

Merged
merged 1 commit into from
Mar 17, 2023
Merged

patches: bump to 19.8.1 #284

merged 1 commit into from
Mar 17, 2023

Conversation

baparham
Copy link
Contributor

No description provided.

@baparham baparham requested a review from robertsLando March 16, 2023 09:52
Copy link
Contributor

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baparham I'm not a master in patches but for what I can see it looks goot to me, tried to test the result patch ?

@baparham
Copy link
Contributor Author

baparham commented Mar 16, 2023

I'll kick off https://github.com/baparham/pkg-fetch/actions/runs/4436328574/jobs/7784623159 and then test out the windows x64 binary for node 19 when that's done (assuming it builds, haha!)

@baparham baparham mentioned this pull request Mar 16, 2023
@baparham
Copy link
Contributor Author

I am not confident with this patch. I tried upgrading to it with a project that was using node18, and it hits this issue:

node:internal/bootstrap/loaders:363
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'internal/modules/cjs/helpers'
    at requireBuiltin (node:internal/bootstrap/loaders:363:19)
    at pkg/prelude/bootstrap.js:1887:10
    at pkg/prelude/bootstrap.js:1986:3
    at pkg/prelude/bootstrap.js:2259:3
    at readPrelude (node:internal/bootstrap/pkg:31:12)
    at node:internal/bootstrap/pkg:36:18
    at node:internal/bootstrap/pkg:43:4
    at node:internal/bootstrap/pkg:44:2

but I'm not sure what's related to upgrading from node18 to node19 in my client application, or what's related to a bad patch. This error makes me believe that this is in the node patches rather than in my userspace code.

I think this needs more tests, so perhaps this shouldn't block a release. However, I have no idea if this issue affects the older node19 patches as well.

@baparham
Copy link
Contributor Author

ugh, I completely forgot that I also need https://github.com/vercel/pkg/pull/1862/files for this to work. Good opportunity to test that patch out I guess!!

@baparham
Copy link
Contributor Author

ugh, I completely forgot that I also need https://github.com/vercel/pkg/pull/1862/files for this to work. Good opportunity to test that patch out I guess!!

works now 🙄 so I think this can be merged

@baparham baparham merged commit 75f1e00 into vercel:main Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants