-
Notifications
You must be signed in to change notification settings - Fork 201
Revive cross compile and bump patches to latest #280
Conversation
based on suggested change from nodejs/node#45756
Full build workflow running over in my fork for this branch here: https://github.com/baparham/pkg-fetch/actions/runs/4368413726 That really needs to pass to be sure the builds aren't broken, but I also have no way of actually runtime testing the arm binaries. Can someone else help out with testing those out once they are built to be sure ARM builds are in fact still working when cross compiled? |
@baparham I can |
🤞 Lets make PKG great again. 😅 |
Hey @baparham, I tested these on an M1 Mac using Docker, and they all appear to work. Here's a repo if anyone wants to reproduce: https://github.com/ospencer/test-pkg-fetch It's a pretty basic hello world smoke test, but I figured that was sufficient. |
(To clarify, specifically I tested the Linux arm64 binaries—not sure if you need alpine, Windows, and friends tested too.) |
Seems to be enough confirmation for me, @robertsLando shall we merge this in? |
ah, not quite yet, I need to drop the last debug commit first, I'll push again |
7a68ea6
to
9aaccd4
Compare
Sorry for late feedback, have been very busy last weeks, yeah let's do this :) |
@robertsLando Are you also planning to do a release? 🙏 |
Release wouldnt hurt 🙏 |
Yeah, I'll reach out to him. In the meantime we could probably try and sneak in the latest 19.8.1 patch set too while we wait till US west coast time. |
build-all.yml
workflow to kick off and wait for all assets to build. To be added on to later with some more automated hash checking, perhaps some more tests (at least on x86) to ensure the built binaries are functional, etc.There is currently a debug commit at the end to allow me to run the full build-all workflow to build all current assets on push to this
revive-cross-compile
branch, which I'll take out once I see the builds all succeed.This would fix #276