Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

[BREAKING] Remove upload and release functions to prepare for CI step. #144

Merged
merged 1 commit into from
Mar 31, 2021
Merged

[BREAKING] Remove upload and release functions to prepare for CI step. #144

merged 1 commit into from
Mar 31, 2021

Conversation

jesec
Copy link
Contributor

@jesec jesec commented Mar 31, 2021 •
edited
Loading

We are going to these in CI workflows instead.

This change greatly simplifies the project.

FYI: This is semver-major.

@jesec
Remove upload and release functions
bd331d3 
We are going to these in CI workflows instead.

This change greatly simplifies the project.
robertsLando
robertsLando suggested changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. BTW I would replace request with got or another module as request is deprecated, also I would use semver to get major version instead of using a custom method

@jesec
Copy link
Contributor Author

jesec commented Mar 31, 2021

Looks good overall. BTW I would replace request with got or another module as request is deprecated, also I would use semver to get major version instead of using a custom method

Well. I just moved things around. request and that getMajor function are already there. IMO we can do that in a separate change.

robertsLando
robertsLando approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok no problem. LGTM

@leerob leerob changed the title Remove upload and release functions [BREAKING] Remove upload and release functions to prepare for CI step. Mar 31, 2021
@leerob leerob merged commit e314198 into master Mar 31, 2021
@leerob leerob deleted the pr/drop-upload branch March 31, 2021 14:03
@jesec jesec mentioned this pull request Mar 31, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertsLando robertsLando robertsLando approved these changes

@hipstersmoothie hipstersmoothie Awaiting requested review from hipstersmoothie

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesec @robertsLando @leerob