Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

patches: drop Node < 8 and old point releases #140

Merged
merged 1 commit into from
Mar 29, 2021
Merged

patches: drop Node < 8 and old point releases #140

merged 1 commit into from
Mar 29, 2021

Conversation

jesec
Copy link
Contributor

@jesec jesec commented Mar 29, 2021

No description provided.

@robertsLando
Copy link
Contributor

I already did this on my pull #135

@jesec
Copy link
Contributor Author

jesec commented Mar 29, 2021

I already did this on my pull #135

This branch is there since last week.

#135 is becoming too bloated. We have to split changes to different commits and preserve proper authorship.

robertsLando
robertsLando reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesec
Copy link
Contributor Author

jesec commented Mar 29, 2021

BTW: @leerob Please enable "Rebase and merge" option.

@jesec jesec merged commit d8a494b into master Mar 29, 2021
@jesec jesec deleted the pr/drop-deprecated branch March 29, 2021 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertsLando robertsLando robertsLando left review comments

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesec @robertsLando