Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

patches: add Node.js 16.0.0 #123

Merged
merged 5 commits into from
Apr 23, 2021
Merged

patches: add Node.js 16.0.0 #123

merged 5 commits into from
Apr 23, 2021

Conversation

jesec
Copy link
Contributor

@jesec jesec commented Mar 23, 2021 •
edited
Loading

No description provided.

@erossignon
Copy link

you can put the PR in Draft mode to avoid 'accidental' merging

@robertsLando robertsLando marked this pull request as draft April 3, 2021 09:59
@jesec jesec marked this pull request as ready for review April 21, 2021 23:57
@jesec jesec force-pushed the pr/node-16 branch 2 times, most recently from d051cc7 to 5c9ed5c Compare April 22, 2021 14:07
@jesec
patches: add Node.js 16.0.0
6b3d21c 
Test: manual, node v16.0.0
@jesec
patches: apply nodejs/node@ea694e2b1 to 16
e1346ee
@jesec
CI: add Node 16, drop Node 8
5405bf1
@jesec
Revert "CI: don't fetch, build only"
7664fa8 
This reverts commit e9c2efa.

We don't want to waste resources. Plus, with #169, it is mandatory
to bump minor if there is any change of binary.
@jesec
CI: don't upload if binary is not compiled
cbf9a05
@jesec
Copy link
Contributor Author

jesec commented Apr 23, 2021

Build succeeds in my own repo. We are good to go.

@jesec jesec merged commit 7c8ca68 into master Apr 23, 2021
@jesec jesec deleted the pr/node-16 branch April 23, 2021 15:01
@jesec
Copy link
Contributor Author

jesec commented Apr 23, 2021

Workflows started:

alpine: https://github.com/vercel/pkg-fetch/actions/runs/778165607

linux: https://github.com/vercel/pkg-fetch/actions/runs/778165672

linuxstatic: https://github.com/vercel/pkg-fetch/actions/runs/778165846

win: https://github.com/vercel/pkg-fetch/actions/runs/778166018

macos: https://github.com/vercel/pkg-fetch/actions/runs/778166261

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesec @erossignon @robertsLando