Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

🚀 fix: correctly resolve armv7 host #101

Closed
wants to merge 1 commit into from
Closed

Conversation

n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Aug 19, 2020

Relying on /proc/cpuinfo' is not safe as it will not work when using emulation for building the binaries such as docker buildx.

uname -m is more reliably as it will return a string such as armv7.

Relying on `/proc/cpuinfo'` is not safe as it will not work when using emulation for building the binaries such as docker buildx.
@robertsLando
Copy link
Contributor

@igorklopov

@n1ru4l n1ru4l changed the title fix: correctly resolve armv7 host 🚀 fix: correctly resolve armv7 host Aug 20, 2020
@robertsLando
Copy link
Contributor

@leerob please consider merging this

@leerob
Copy link
Member

leerob commented Mar 1, 2021

Replaced by #106.

@n1ru4l if you would change anything about that, I'm happy to merge a follow-up PR.

@leerob leerob closed this Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants