Prevent URL from being updated while asPath is delayed #8756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| buildDuration | 17s | 16.6s | -360ms |
| nodeModulesSize | 42 MB | 42 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.js | 18.2 kB | 18.2 kB | -46 B |
| main-HASH.js gzip | 6.66 kB | 6.65 kB | -11 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..2b8407376.js | 21.9 kB | 21.9 kB | ✓ |
| 4952ddcd88e7..7376.js gzip | 7.81 kB | 7.81 kB | ✓ |
| de003c3a9d30..1c5d17695.js | 43.1 kB | N/A | N/A |
| de003c3a9d30..7695.js gzip | 15.4 kB | N/A | N/A |
| framework.5b..dbaff70d3.js | 125 kB | 125 kB | ✓ |
| framework.5b..70d3.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..3fa59b1f5.js | N/A | 43.1 kB | N/A |
| de003c3a9d30..b1f5.js gzip | N/A | 15.5 kB | N/A |
| Overall change | 210 kB | 210 kB | -46 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.6 kB | 16.5 kB | -50 B |
| main-HASH.module.js gzip | 6.4 kB | 6.39 kB | -11 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5f.module.js | 45.5 kB | N/A | N/A |
| de003c3a9d30..dule.js gzip | 16.5 kB | N/A | N/A |
| framework.5b..d3.module.js | 125 kB | 125 kB | ✓ |
| framework.5b..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..4b.module.js | N/A | 45.5 kB | N/A |
| de003c3a9d30..dule.js gzip | N/A | 16.5 kB | N/A |
| Overall change | 189 kB | 189 kB | -50 B |
Client Pages
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.js | 1.81 kB | 1.81 kB | ✓ |
| _app.js gzip | 873 B | 873 B | ✓ |
| _error.js | 12 kB | 12 kB | ✓ |
| _error.js gzip | 4.73 kB | 4.73 kB | ✓ |
| hooks.js | 12.7 kB | 12.7 kB | ✓ |
| hooks.js gzip | 4.79 kB | 4.79 kB | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 8.14 kB | 8.14 kB | ✓ |
| link.js gzip | 3.5 kB | 3.5 kB | ✓ |
| routerDirect.js | 408 B | 408 B | ✓ |
| routerDirect.js gzip | 281 B | 281 B | ✓ |
| withRouter.js | 419 B | 419 B | ✓ |
| withRouter.js gzip | 280 B | 280 B | ✓ |
| Overall change | 35.8 kB | 35.8 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.module.js | 1.7 kB | 1.7 kB | ✓ |
| _app.module.js gzip | 832 B | 832 B | ✓ |
| _error.module.js | 23.3 kB | 23.3 kB | ✓ |
| _error.module.js gzip | 8.59 kB | 8.59 kB | ✓ |
| hooks.module.js | 1.52 kB | 1.52 kB | ✓ |
| hooks.module.js gzip | 793 B | 793 B | ✓ |
| index.module.js | 294 B | 294 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 8.53 kB | 8.53 kB | ✓ |
| link.module.js gzip | 3.68 kB | 3.68 kB | ✓ |
| routerDirect.module.js | 394 B | 394 B | ✓ |
| routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
| withRouter.module.js | 404 B | 404 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 36.1 kB | 36.1 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _buildManifest.js | 81 B | 81 B | ✓ |
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManifest.module.js | 81 B | 81 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 162 B | 162 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| index.html | 3.62 kB | 3.62 kB | ✓ |
| index.html gzip | 946 B | 946 B | ✓ |
| link.html | 3.66 kB | 3.66 kB | ✓ |
| link.html gzip | 953 B | 953 B | ✓ |
| withRouter.html | 3.67 kB | 3.67 kB | ✓ |
| withRouter.html gzip | 941 B | 941 B | ✓ |
| Overall change | 10.9 kB | 10.9 kB | ✓ |
Diffs
Diff for main-HASH.js
@@ -490,7 +490,7 @@ function () {
var _ref2 = (0, _asyncToGenerator2["default"])(
/*#__PURE__*/
_regeneratorRuntime.mark(function _callee(_temp) {
- var _ref, passedWebpackHMR, initialErr, _require, isValidElementType, initialAsPath, renderCtx;
+ var _ref, passedWebpackHMR, initialErr, _require, isValidElementType, renderCtx;
return _regeneratorRuntime.wrap(function _callee$(_context) {
while (1) {
@@ -547,10 +547,7 @@ function () {
return window.__NEXT_PRELOADREADY(dynamicIds);
case 22:
- // if auto prerendered and dynamic route wait to update asPath
- // until after mount to prevent hydration mismatch
- initialAsPath = (0, _isDynamic.isDynamicRoute)(page) && data.nextExport ? page : asPath;
- exports.router = router = (0, _router.createRouter)(page, query, initialAsPath, {
+ exports.router = router = (0, _router.createRouter)(page, query, asPath, {
initialProps: props,
pageLoader: pageLoader,
App: App,
@@ -580,7 +577,7 @@ function () {
render(renderCtx);
return _context.abrupt("return", emitter);
- case 27:
+ case 26:
case "end":
return _context.stop();
}Diff for main-HASH.module.js
@@ -545,12 +545,9 @@ function () {
if (window.__NEXT_PRELOADREADY) {
yield window.__NEXT_PRELOADREADY(dynamicIds);
- } // if auto prerendered and dynamic route wait to update asPath
- // until after mount to prevent hydration mismatch
-
+ }
- const initialAsPath = (0, _isDynamic.isDynamicRoute)(page) && data.nextExport ? page : asPath;
- exports.router = router = (0, _router.createRouter)(page, query, initialAsPath, {
+ exports.router = router = (0, _router.createRouter)(page, query, asPath, {
initialProps: props,
pageLoader,
App,Diff for index.html
@@ -12,11 +12,11 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
async="" crossorigin="anonymous" nomodule=""></script>
@@ -53,9 +53,9 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Diff for link.html
@@ -14,9 +14,9 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -52,13 +52,13 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Diff for withRouter.html
@@ -14,9 +14,9 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -50,13 +50,13 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| buildDuration | 17.5s | 17.5s | |
| nodeModulesSize | 42 MB | 42 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.js | 18.2 kB | 18.2 kB | -46 B |
| main-HASH.js gzip | 6.66 kB | 6.65 kB | -11 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..2b8407376.js | 21.9 kB | 21.9 kB | ✓ |
| 4952ddcd88e7..7376.js gzip | 7.81 kB | 7.81 kB | ✓ |
| de003c3a9d30..1c5d17695.js | 43.1 kB | N/A | N/A |
| de003c3a9d30..7695.js gzip | 15.4 kB | N/A | N/A |
| framework.5b..dbaff70d3.js | 125 kB | 125 kB | ✓ |
| framework.5b..70d3.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..3fa59b1f5.js | N/A | 43.1 kB | N/A |
| de003c3a9d30..b1f5.js gzip | N/A | 15.5 kB | N/A |
| Overall change | 210 kB | 210 kB | -46 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.6 kB | 16.5 kB | -50 B |
| main-HASH.module.js gzip | 6.4 kB | 6.39 kB | -11 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5f.module.js | 45.5 kB | N/A | N/A |
| de003c3a9d30..dule.js gzip | 16.5 kB | N/A | N/A |
| framework.5b..d3.module.js | 125 kB | 125 kB | ✓ |
| framework.5b..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..4b.module.js | N/A | 45.5 kB | N/A |
| de003c3a9d30..dule.js gzip | N/A | 16.5 kB | N/A |
| Overall change | 189 kB | 189 kB | -50 B |
Client Pages
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.js | 1.81 kB | 1.81 kB | ✓ |
| _app.js gzip | 873 B | 873 B | ✓ |
| _error.js | 12 kB | 12 kB | ✓ |
| _error.js gzip | 4.73 kB | 4.73 kB | ✓ |
| hooks.js | 12.7 kB | 12.7 kB | ✓ |
| hooks.js gzip | 4.79 kB | 4.79 kB | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 8.14 kB | 8.14 kB | ✓ |
| link.js gzip | 3.5 kB | 3.5 kB | ✓ |
| routerDirect.js | 408 B | 408 B | ✓ |
| routerDirect.js gzip | 281 B | 281 B | ✓ |
| withRouter.js | 419 B | 419 B | ✓ |
| withRouter.js gzip | 280 B | 280 B | ✓ |
| Overall change | 35.8 kB | 35.8 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.module.js | 1.7 kB | 1.7 kB | ✓ |
| _app.module.js gzip | 832 B | 832 B | ✓ |
| _error.module.js | 23.3 kB | 23.3 kB | ✓ |
| _error.module.js gzip | 8.59 kB | 8.59 kB | ✓ |
| hooks.module.js | 1.52 kB | 1.52 kB | ✓ |
| hooks.module.js gzip | 793 B | 793 B | ✓ |
| index.module.js | 294 B | 294 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 8.53 kB | 8.53 kB | ✓ |
| link.module.js gzip | 3.68 kB | 3.68 kB | ✓ |
| routerDirect.module.js | 394 B | 394 B | ✓ |
| routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
| withRouter.module.js | 404 B | 404 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 36.1 kB | 36.1 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _buildManifest.js | 81 B | 81 B | ✓ |
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManifest.module.js | 81 B | 81 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 162 B | 162 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _error.js | 248 kB | 248 kB | |
| _error.js gzip | 66.2 kB | 66.3 kB | |
| hooks.html | 3.75 kB | 3.75 kB | ✓ |
| hooks.html gzip | 978 B | 978 B | ✓ |
| index.js | 248 kB | 248 kB | |
| index.js gzip | 66.5 kB | 66.6 kB | |
| link.js | 256 kB | 256 kB | |
| link.js gzip | 68.5 kB | 68.6 kB | |
| routerDirect.js | 249 kB | 249 kB | |
| routerDirect.js gzip | 66.5 kB | 66.6 kB | |
| withRouter.js | 249 kB | 249 kB | |
| withRouter.js gzip | 66.6 kB | 66.7 kB | |
| Overall change | 1.25 MB | 1.25 MB |
Commit: a15312f
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| buildDuration | 15.9s | 15.4s | -445ms |
| nodeModulesSize | 42 MB | 42 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.js | 18.2 kB | 18.2 kB | -46 B |
| main-HASH.js gzip | 6.66 kB | 6.65 kB | -11 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..2b8407376.js | 21.9 kB | 21.9 kB | ✓ |
| 4952ddcd88e7..7376.js gzip | 7.81 kB | 7.81 kB | ✓ |
| de003c3a9d30..1c5d17695.js | 43.1 kB | N/A | N/A |
| de003c3a9d30..7695.js gzip | 15.4 kB | N/A | N/A |
| framework.5b..dbaff70d3.js | 125 kB | 125 kB | ✓ |
| framework.5b..70d3.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..3fa59b1f5.js | N/A | 43.1 kB | N/A |
| de003c3a9d30..b1f5.js gzip | N/A | 15.5 kB | N/A |
| Overall change | 210 kB | 210 kB | -46 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.6 kB | 16.5 kB | -50 B |
| main-HASH.module.js gzip | 6.4 kB | 6.39 kB | -11 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5f.module.js | 45.5 kB | N/A | N/A |
| de003c3a9d30..dule.js gzip | 16.5 kB | N/A | N/A |
| framework.5b..d3.module.js | 125 kB | 125 kB | ✓ |
| framework.5b..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..4b.module.js | N/A | 45.5 kB | N/A |
| de003c3a9d30..dule.js gzip | N/A | 16.5 kB | N/A |
| Overall change | 189 kB | 189 kB | -50 B |
Client Pages
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.js | 1.81 kB | 1.81 kB | ✓ |
| _app.js gzip | 873 B | 873 B | ✓ |
| _error.js | 12 kB | 12 kB | ✓ |
| _error.js gzip | 4.73 kB | 4.73 kB | ✓ |
| hooks.js | 12.7 kB | 12.7 kB | ✓ |
| hooks.js gzip | 4.79 kB | 4.79 kB | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 8.14 kB | 8.14 kB | ✓ |
| link.js gzip | 3.5 kB | 3.5 kB | ✓ |
| routerDirect.js | 408 B | 408 B | ✓ |
| routerDirect.js gzip | 281 B | 281 B | ✓ |
| withRouter.js | 419 B | 419 B | ✓ |
| withRouter.js gzip | 280 B | 280 B | ✓ |
| Overall change | 35.8 kB | 35.8 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.module.js | 1.7 kB | 1.7 kB | ✓ |
| _app.module.js gzip | 832 B | 832 B | ✓ |
| _error.module.js | 23.3 kB | 23.3 kB | ✓ |
| _error.module.js gzip | 8.59 kB | 8.59 kB | ✓ |
| hooks.module.js | 1.52 kB | 1.52 kB | ✓ |
| hooks.module.js gzip | 793 B | 793 B | ✓ |
| index.module.js | 294 B | 294 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 8.53 kB | 8.53 kB | ✓ |
| link.module.js gzip | 3.68 kB | 3.68 kB | ✓ |
| routerDirect.module.js | 394 B | 394 B | ✓ |
| routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
| withRouter.module.js | 404 B | 404 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 36.1 kB | 36.1 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _buildManifest.js | 81 B | 81 B | ✓ |
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManifest.module.js | 81 B | 81 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 162 B | 162 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| index.html | 3.62 kB | 3.62 kB | ✓ |
| index.html gzip | 946 B | 946 B | ✓ |
| link.html | 3.66 kB | 3.66 kB | ✓ |
| link.html gzip | 953 B | 953 B | ✓ |
| withRouter.html | 3.67 kB | 3.67 kB | ✓ |
| withRouter.html gzip | 941 B | 941 B | ✓ |
| Overall change | 10.9 kB | 10.9 kB | ✓ |
Diffs
Diff for main-HASH.js
@@ -490,7 +490,7 @@ function () {
var _ref2 = (0, _asyncToGenerator2["default"])(
/*#__PURE__*/
_regeneratorRuntime.mark(function _callee(_temp) {
- var _ref, passedWebpackHMR, initialErr, _require, isValidElementType, initialAsPath, renderCtx;
+ var _ref, passedWebpackHMR, initialErr, _require, isValidElementType, renderCtx;
return _regeneratorRuntime.wrap(function _callee$(_context) {
while (1) {
@@ -547,10 +547,7 @@ function () {
return window.__NEXT_PRELOADREADY(dynamicIds);
case 22:
- // if auto prerendered and dynamic route wait to update asPath
- // until after mount to prevent hydration mismatch
- initialAsPath = (0, _isDynamic.isDynamicRoute)(page) && data.nextExport ? page : asPath;
- exports.router = router = (0, _router.createRouter)(page, query, initialAsPath, {
+ exports.router = router = (0, _router.createRouter)(page, query, asPath, {
initialProps: props,
pageLoader: pageLoader,
App: App,
@@ -580,7 +577,7 @@ function () {
render(renderCtx);
return _context.abrupt("return", emitter);
- case 27:
+ case 26:
case "end":
return _context.stop();
}Diff for main-HASH.module.js
@@ -545,12 +545,9 @@ function () {
if (window.__NEXT_PRELOADREADY) {
yield window.__NEXT_PRELOADREADY(dynamicIds);
- } // if auto prerendered and dynamic route wait to update asPath
- // until after mount to prevent hydration mismatch
-
+ }
- const initialAsPath = (0, _isDynamic.isDynamicRoute)(page) && data.nextExport ? page : asPath;
- exports.router = router = (0, _router.createRouter)(page, query, initialAsPath, {
+ exports.router = router = (0, _router.createRouter)(page, query, asPath, {
initialProps: props,
pageLoader,
App,Diff for index.html
@@ -12,11 +12,11 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
async="" crossorigin="anonymous" nomodule=""></script>
@@ -53,9 +53,9 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Diff for link.html
@@ -14,9 +14,9 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -52,13 +52,13 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Diff for withRouter.html
@@ -14,9 +14,9 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -50,13 +50,13 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| buildDuration | 15.8s | 15.5s | -379ms |
| nodeModulesSize | 42 MB | 42 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.js | 18.2 kB | 18.2 kB | -46 B |
| main-HASH.js gzip | 6.66 kB | 6.65 kB | -11 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..2b8407376.js | 21.9 kB | 21.9 kB | ✓ |
| 4952ddcd88e7..7376.js gzip | 7.81 kB | 7.81 kB | ✓ |
| de003c3a9d30..1c5d17695.js | 43.1 kB | N/A | N/A |
| de003c3a9d30..7695.js gzip | 15.4 kB | N/A | N/A |
| framework.5b..dbaff70d3.js | 125 kB | 125 kB | ✓ |
| framework.5b..70d3.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..3fa59b1f5.js | N/A | 43.1 kB | N/A |
| de003c3a9d30..b1f5.js gzip | N/A | 15.5 kB | N/A |
| Overall change | 210 kB | 210 kB | -46 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.6 kB | 16.5 kB | -50 B |
| main-HASH.module.js gzip | 6.4 kB | 6.39 kB | -11 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5f.module.js | 45.5 kB | N/A | N/A |
| de003c3a9d30..dule.js gzip | 16.5 kB | N/A | N/A |
| framework.5b..d3.module.js | 125 kB | 125 kB | ✓ |
| framework.5b..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..4b.module.js | N/A | 45.5 kB | N/A |
| de003c3a9d30..dule.js gzip | N/A | 16.5 kB | N/A |
| Overall change | 189 kB | 189 kB | -50 B |
Client Pages
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.js | 1.81 kB | 1.81 kB | ✓ |
| _app.js gzip | 873 B | 873 B | ✓ |
| _error.js | 12 kB | 12 kB | ✓ |
| _error.js gzip | 4.73 kB | 4.73 kB | ✓ |
| hooks.js | 12.7 kB | 12.7 kB | ✓ |
| hooks.js gzip | 4.79 kB | 4.79 kB | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 8.14 kB | 8.14 kB | ✓ |
| link.js gzip | 3.5 kB | 3.5 kB | ✓ |
| routerDirect.js | 408 B | 408 B | ✓ |
| routerDirect.js gzip | 281 B | 281 B | ✓ |
| withRouter.js | 419 B | 419 B | ✓ |
| withRouter.js gzip | 280 B | 280 B | ✓ |
| Overall change | 35.8 kB | 35.8 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.module.js | 1.7 kB | 1.7 kB | ✓ |
| _app.module.js gzip | 832 B | 832 B | ✓ |
| _error.module.js | 23.3 kB | 23.3 kB | ✓ |
| _error.module.js gzip | 8.59 kB | 8.59 kB | ✓ |
| hooks.module.js | 1.52 kB | 1.52 kB | ✓ |
| hooks.module.js gzip | 793 B | 793 B | ✓ |
| index.module.js | 294 B | 294 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 8.53 kB | 8.53 kB | ✓ |
| link.module.js gzip | 3.68 kB | 3.68 kB | ✓ |
| routerDirect.module.js | 394 B | 394 B | ✓ |
| routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
| withRouter.module.js | 404 B | 404 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 36.1 kB | 36.1 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _buildManifest.js | 81 B | 81 B | ✓ |
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManifest.module.js | 81 B | 81 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 162 B | 162 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _error.js | 248 kB | 248 kB | |
| _error.js gzip | 66.2 kB | 66.3 kB | |
| hooks.html | 3.75 kB | 3.75 kB | ✓ |
| hooks.html gzip | 978 B | 978 B | ✓ |
| index.js | 248 kB | 248 kB | |
| index.js gzip | 66.5 kB | 66.6 kB | |
| link.js | 256 kB | 256 kB | |
| link.js gzip | 68.5 kB | 68.6 kB | |
| routerDirect.js | 249 kB | 249 kB | |
| routerDirect.js gzip | 66.5 kB | 66.6 kB | |
| withRouter.js | 249 kB | 249 kB | |
| withRouter.js gzip | 66.6 kB | 66.7 kB | |
| Overall change | 1.25 MB | 1.25 MB |
Commit: f5b8168
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| buildDuration | 16.3s | 17.1s | |
| nodeModulesSize | 41.9 MB | 41.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.js | 18.2 kB | 18.2 kB | -46 B |
| main-HASH.js gzip | 6.66 kB | 6.65 kB | -11 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..2b8407376.js | 21.9 kB | 21.9 kB | ✓ |
| 4952ddcd88e7..7376.js gzip | 7.81 kB | 7.81 kB | ✓ |
| de003c3a9d30..1c5d17695.js | 43.1 kB | N/A | N/A |
| de003c3a9d30..7695.js gzip | 15.4 kB | N/A | N/A |
| framework.5b..dbaff70d3.js | 125 kB | 125 kB | ✓ |
| framework.5b..70d3.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..3fa59b1f5.js | N/A | 43.1 kB | N/A |
| de003c3a9d30..b1f5.js gzip | N/A | 15.5 kB | N/A |
| Overall change | 210 kB | 210 kB | -46 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.6 kB | 16.5 kB | -50 B |
| main-HASH.module.js gzip | 6.4 kB | 6.39 kB | -11 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5f.module.js | 45.5 kB | N/A | N/A |
| de003c3a9d30..dule.js gzip | 16.5 kB | N/A | N/A |
| framework.5b..d3.module.js | 125 kB | 125 kB | ✓ |
| framework.5b..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..4b.module.js | N/A | 45.5 kB | N/A |
| de003c3a9d30..dule.js gzip | N/A | 16.5 kB | N/A |
| Overall change | 189 kB | 189 kB | -50 B |
Client Pages
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.js | 1.81 kB | 1.81 kB | ✓ |
| _app.js gzip | 873 B | 873 B | ✓ |
| _error.js | 12 kB | 12 kB | ✓ |
| _error.js gzip | 4.73 kB | 4.73 kB | ✓ |
| hooks.js | 12.7 kB | 12.7 kB | ✓ |
| hooks.js gzip | 4.79 kB | 4.79 kB | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 8.14 kB | 8.14 kB | ✓ |
| link.js gzip | 3.5 kB | 3.5 kB | ✓ |
| routerDirect.js | 408 B | 408 B | ✓ |
| routerDirect.js gzip | 281 B | 281 B | ✓ |
| withRouter.js | 419 B | 419 B | ✓ |
| withRouter.js gzip | 280 B | 280 B | ✓ |
| Overall change | 35.8 kB | 35.8 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.module.js | 1.7 kB | 1.7 kB | ✓ |
| _app.module.js gzip | 832 B | 832 B | ✓ |
| _error.module.js | 23.3 kB | 23.3 kB | ✓ |
| _error.module.js gzip | 8.59 kB | 8.59 kB | ✓ |
| hooks.module.js | 1.52 kB | 1.52 kB | ✓ |
| hooks.module.js gzip | 793 B | 793 B | ✓ |
| index.module.js | 294 B | 294 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 8.53 kB | 8.53 kB | ✓ |
| link.module.js gzip | 3.68 kB | 3.68 kB | ✓ |
| routerDirect.module.js | 394 B | 394 B | ✓ |
| routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
| withRouter.module.js | 404 B | 404 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 36.1 kB | 36.1 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _buildManifest.js | 81 B | 81 B | ✓ |
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManifest.module.js | 81 B | 81 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 162 B | 162 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| index.html | 3.62 kB | 3.62 kB | ✓ |
| index.html gzip | 946 B | 946 B | ✓ |
| link.html | 3.66 kB | 3.66 kB | ✓ |
| link.html gzip | 953 B | 953 B | ✓ |
| withRouter.html | 3.67 kB | 3.67 kB | ✓ |
| withRouter.html gzip | 941 B | 941 B | ✓ |
| Overall change | 10.9 kB | 10.9 kB | ✓ |
Diffs
Diff for main-HASH.js
@@ -490,7 +490,7 @@ function () {
var _ref2 = (0, _asyncToGenerator2["default"])(
/*#__PURE__*/
_regeneratorRuntime.mark(function _callee(_temp) {
- var _ref, passedWebpackHMR, initialErr, _require, isValidElementType, initialAsPath, renderCtx;
+ var _ref, passedWebpackHMR, initialErr, _require, isValidElementType, renderCtx;
return _regeneratorRuntime.wrap(function _callee$(_context) {
while (1) {
@@ -547,10 +547,7 @@ function () {
return window.__NEXT_PRELOADREADY(dynamicIds);
case 22:
- // if auto prerendered and dynamic route wait to update asPath
- // until after mount to prevent hydration mismatch
- initialAsPath = (0, _isDynamic.isDynamicRoute)(page) && data.nextExport ? page : asPath;
- exports.router = router = (0, _router.createRouter)(page, query, initialAsPath, {
+ exports.router = router = (0, _router.createRouter)(page, query, asPath, {
initialProps: props,
pageLoader: pageLoader,
App: App,
@@ -580,7 +577,7 @@ function () {
render(renderCtx);
return _context.abrupt("return", emitter);
- case 27:
+ case 26:
case "end":
return _context.stop();
}Diff for main-HASH.module.js
@@ -545,12 +545,9 @@ function () {
if (window.__NEXT_PRELOADREADY) {
yield window.__NEXT_PRELOADREADY(dynamicIds);
- } // if auto prerendered and dynamic route wait to update asPath
- // until after mount to prevent hydration mismatch
-
+ }
- const initialAsPath = (0, _isDynamic.isDynamicRoute)(page) && data.nextExport ? page : asPath;
- exports.router = router = (0, _router.createRouter)(page, query, initialAsPath, {
+ exports.router = router = (0, _router.createRouter)(page, query, asPath, {
initialProps: props,
pageLoader,
App,Diff for index.html
@@ -12,11 +12,11 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
async="" crossorigin="anonymous" nomodule=""></script>
@@ -53,9 +53,9 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Diff for link.html
@@ -14,9 +14,9 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -52,13 +52,13 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Diff for withRouter.html
@@ -14,9 +14,9 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
as="script" crossorigin="anonymous" />
@@ -50,13 +50,13 @@
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.884fe048044e62151ce8.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.01cc4f1e34fde13f4eb9.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.148b9d567c5ec499c554.module.js"
+ <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.b5ebf6f8ef4730ac0f13.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-aaf2a46cf6229d77a673.js"
+ <script src="/_next/static/runtime/main-65bc2484fc43d8f089ac.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-bfc245da822f4d93e09f.module.js"
+ <script src="/_next/static/runtime/main-7deb306e291c1b6b6772.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| buildDuration | 16.9s | 16.7s | -132ms |
| nodeModulesSize | 41.9 MB | 41.9 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.js | 18.2 kB | 18.2 kB | -46 B |
| main-HASH.js gzip | 6.66 kB | 6.65 kB | -11 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 4952ddcd88e7..2b8407376.js | 21.9 kB | 21.9 kB | ✓ |
| 4952ddcd88e7..7376.js gzip | 7.81 kB | 7.81 kB | ✓ |
| de003c3a9d30..1c5d17695.js | 43.1 kB | N/A | N/A |
| de003c3a9d30..7695.js gzip | 15.4 kB | N/A | N/A |
| framework.5b..dbaff70d3.js | 125 kB | 125 kB | ✓ |
| framework.5b..70d3.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..3fa59b1f5.js | N/A | 43.1 kB | N/A |
| de003c3a9d30..b1f5.js gzip | N/A | 15.5 kB | N/A |
| Overall change | 210 kB | 210 kB | -46 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| main-HASH.module.js | 16.6 kB | 16.5 kB | -50 B |
| main-HASH.module.js gzip | 6.4 kB | 6.39 kB | -11 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..5f.module.js | 45.5 kB | N/A | N/A |
| de003c3a9d30..dule.js gzip | 16.5 kB | N/A | N/A |
| framework.5b..d3.module.js | 125 kB | 125 kB | ✓ |
| framework.5b..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| de003c3a9d30..4b.module.js | N/A | 45.5 kB | N/A |
| de003c3a9d30..dule.js gzip | N/A | 16.5 kB | N/A |
| Overall change | 189 kB | 189 kB | -50 B |
Client Pages
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.js | 1.81 kB | 1.81 kB | ✓ |
| _app.js gzip | 873 B | 873 B | ✓ |
| _error.js | 12 kB | 12 kB | ✓ |
| _error.js gzip | 4.73 kB | 4.73 kB | ✓ |
| hooks.js | 12.7 kB | 12.7 kB | ✓ |
| hooks.js gzip | 4.79 kB | 4.79 kB | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 8.14 kB | 8.14 kB | ✓ |
| link.js gzip | 3.5 kB | 3.5 kB | ✓ |
| routerDirect.js | 408 B | 408 B | ✓ |
| routerDirect.js gzip | 281 B | 281 B | ✓ |
| withRouter.js | 419 B | 419 B | ✓ |
| withRouter.js gzip | 280 B | 280 B | ✓ |
| Overall change | 35.8 kB | 35.8 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _app.module.js | 1.7 kB | 1.7 kB | ✓ |
| _app.module.js gzip | 832 B | 832 B | ✓ |
| _error.module.js | 23.3 kB | 23.3 kB | ✓ |
| _error.module.js gzip | 8.59 kB | 8.59 kB | ✓ |
| hooks.module.js | 1.52 kB | 1.52 kB | ✓ |
| hooks.module.js gzip | 793 B | 793 B | ✓ |
| index.module.js | 294 B | 294 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 8.53 kB | 8.53 kB | ✓ |
| link.module.js gzip | 3.68 kB | 3.68 kB | ✓ |
| routerDirect.module.js | 394 B | 394 B | ✓ |
| routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
| withRouter.module.js | 404 B | 404 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 36.1 kB | 36.1 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _buildManifest.js | 81 B | 81 B | ✓ |
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManifest.module.js | 81 B | 81 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 162 B | 162 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js tweak/aspath-updating | Change | |
|---|---|---|---|
| _error.js | 248 kB | 248 kB | |
| _error.js gzip | 66.2 kB | 66.3 kB | |
| hooks.html | 3.75 kB | 3.75 kB | ✓ |
| hooks.html gzip | 978 B | 978 B | ✓ |
| index.js | 248 kB | 248 kB | |
| index.js gzip | 66.5 kB | 66.6 kB | |
| link.js | 256 kB | 256 kB | |
| link.js gzip | 68.5 kB | 68.6 kB | |
| routerDirect.js | 249 kB | 249 kB | |
| routerDirect.js gzip | 66.5 kB | 66.6 kB | |
| withRouter.js | 249 kB | 249 kB | |
| withRouter.js gzip | 66.6 kB | 66.7 kB | |
| Overall change | 1.25 MB | 1.25 MB |
Commit: d750495
Timer
approved these changes
Sep 16, 2019
This was referenced Jun 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page is auto prerendered we delay updating the
asPathuntil after mount to prevent breaking hydration. To prevent the URL from flashing this moves the populating ofasPathinto the routerFixes: #8749