Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move should not cause error when removing loading.js to flaky manifest #75239

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 23, 2025

Moved should not cause error when removing loading.js test to flaky manifest.

x-ref: Flakiness Metrics

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Jan 23, 2025
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi changed the title test: deflake e2e/app-dir/app-compilation/index.test.ts test: deflake should not cause error when removing loading.js Jan 23, 2025
@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 23, 2025 18:35
@ijjk
Copy link
Member

ijjk commented Jan 23, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 23, 2025

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
buildDuration 18.2s 15.4s N/A
buildDurationCached 14.5s 12.1s N/A
nodeModulesSize 419 MB 419 MB N/A
nextStartRea..uration (ms) 414ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
5306-HASH.js gzip 54.1 kB 54.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
index.html gzip 523 B 524 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 378 kB 378 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 365 kB 365 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.49 MB 2.49 MB
build cache
vercel/next.js canary vercel/next.js 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75.8 kB 75.5 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: dffd804

@devjiwonchoi devjiwonchoi changed the title test: deflake should not cause error when removing loading.js test: Move should not cause error when removing loading.js to flaky manifest Jan 23, 2025
@devjiwonchoi devjiwonchoi requested a review from ijjk January 23, 2025 21:22
@devjiwonchoi devjiwonchoi merged commit b29b6aa into canary Jan 23, 2025
135 checks passed
Copy link
Member Author

Merge activity

  • Jan 23, 4:39 PM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi deleted the 01-24-test_deflake_e2e_app-dir_app-compilation_index.test.ts branch January 23, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants