fix: typeof msg should compare to object

[HQidea]

Fixing a bug

The code is located at

next.js/packages/next/src/server/lib/start-server.ts

Line 429 in c33eb2b

if (msg && typeof msg && msg.nextWorkerOptions && process.send) {

typeof msg should be compared to 'object'. Otherwise, it makes no sense.

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 8ebc1d3

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[eps1lon]

Thank you!

[ijjk]

Failing test suites

Commit: 8ebc1d3

pnpm test-dev-turbo test/e2e/app-dir/app-compilation/index.test.ts (turbopack)

• app dir > HMR > should not cause error when removing loading.js

Expand output

● app dir › HMR › should not cause error when removing loading.js

expect(received).toInclude(expected)

Expected string to include:
  "✓ Compiled"
Received:
  " ○ Compiling /page-with-loading ...
"

  38 |
  39 |         await retry(async () => {
> 40 |           expect(next.cliOutput.slice(cliOutputLength)).toInclude('✓ Compiled')
     |                                                         ^
  41 |         })
  42 |
  43 |         // It should not have an error

  at toInclude (e2e/app-dir/app-compilation/index.test.ts:40:57)
  at fn (lib/next-test-utils.ts:806:20)
  at Object.<anonymous> (e2e/app-dir/app-compilation/index.test.ts:39:9)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/persistent-caching/persistent-caching.test.ts (PPR)

• persistent-caching > should persistent cache loaders

Expand output

● persistent-caching › should persistent cache loaders

expect(received).toBe(expected) // Object.is equality

Expected: "Timestamp = 1737659848871"
Received: "Timestamp = 1737659868406"

  55 |       const browser = await next.browser('/pages')
  56 |       // TODO Persistent Caching for webpack dev server is broken
> 57 |       expect(await browser.elementByCss('main').text()).toBe(pagesTimestamp)
     |                                                         ^
  58 |       await browser.close()
  59 |     }
  60 |   })

  at Object.toBe (e2e/persistent-caching/persistent-caching.test.ts:57:57)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
buildDuration	18.5s	16.2s	N/A
buildDurationCached	15.3s	13s	N/A
nodeModulesSize	419 MB	419 MB	⚠️ +228 B
nextStartRea..uration (ms)	425ms	419ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
5306-HASH.js gzip	54.1 kB	54.1 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	241 B	241 B	✓
main-HASH.js gzip	34.6 kB	34.6 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	241 B	241 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
index.html gzip	523 B	522 B	N/A
link.html gzip	538 B	536 B	N/A
withRouter.html gzip	519 B	519 B	✓
Overall change	519 B	519 B	✓

Edge SSR bundle Size

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	210 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
middleware-b..fest.js gzip	671 B	667 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	378 kB	378 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	365 kB	365 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	27.7 kB	27.7 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.49 MB	2.49 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	HQidea/next.js fix-typeof	Change
0.pack gzip	2.1 MB	2.1 MB	⚠️ +423 B
index.pack gzip	75.5 kB	74.6 kB	N/A
Overall change	2.1 MB	2.1 MB	⚠️ +423 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 8ebc1d3

[HQidea]

@eps1lon I have fixed the code style issue, pls approve CI run again. Thx.