add test case for intercepting route + catchall + generateStaticParams #75167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
ztanner
force-pushed
the
01-21-add_test_case_for_intercepting_route_catchall_generatestaticparams
branch
from
4ae930f to
d889859
Compare
ijjk
approved these changes
Jan 22, 2025
ztanner
deleted the
01-21-add_test_case_for_intercepting_route_catchall_generatestaticparams
branch
ztanner
added a commit
that referenced
this pull request
Jan 22, 2025
#75167) This case is fixed on `canary`, but has a regression on 15.1. This PR adds a test case that succeeds on `canary` but fails on the backport branch. A fix for the backport branch is forthcoming.
ztanner
added a commit
that referenced
this pull request
Jan 22, 2025
…icParams (#75170) Backports the testcase added in #75167 in [9bf61bc](9bf61bc). Confirmed failure via [this run](https://github.com/vercel/next.js/actions/runs/12898849331/job/35966678688?pr=75170) Adds the fix in [0ab1e32](0ab1e32). This change is identical to the code used in canary, which was added as part of the `rootParams` feature via #73816 ([ref](https://github.com/vercel/next.js/blob/d12e2e82b778eef8393f47944a258a55c6c508fe/packages/next/src/build/static-paths/app.ts#L316-L317)) This regression was caused by `segments` containing all possible segments (including parallel routes), not just the page segment. As a result, `paramKeys` was incorrectly being calculated. We don't need to traverse the segments to determine the param keys: we have the route regex & matcher, it's more reliable to extract it from that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case is fixed on
canary, but has a regression on 15.1. This PR adds a test case that succeeds oncanarybut fails on the backport branch. A fix for the backport branch is forthcoming.