Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] Gather Feedback per Error #74908

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 15, 2025

Gather feedback per error, not the whole overlay. Added map to store errorCode value as key and boolean for voted.

Before

CleanShot.2025-01-15.at.15.10.42.mp4

After

CleanShot.2025-01-15.at.15.11.26.mp4

Closes NDX-621

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 15, 2025 06:09
@ijjk
Copy link
Member

ijjk commented Jan 15, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
buildDuration 17.7s 15.3s N/A
buildDurationCached 14.3s 12.1s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +4.37 kB
nextStartRea..uration (ms) 415ms 425ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
5306-HASH.js gzip 54 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
middleware-b..fest.js gzip 671 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 374 kB 374 kB N/A
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 362 kB 362 kB N/A
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.73 MB 1.73 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-15-_devoverlay_gather_feedback_per_error Change
0.pack gzip 2.09 MB 2.09 MB ⚠️ +1.27 kB
index.pack gzip 75.1 kB 75.6 kB ⚠️ +486 B
Overall change 2.17 MB 2.17 MB ⚠️ +1.75 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 003a61d

@devjiwonchoi devjiwonchoi force-pushed the 01-15-_devoverlay_keep_pagination_on_build_error branch 2 times, most recently from 964c137 to ebe0abe Compare January 16, 2025 12:40
@devjiwonchoi devjiwonchoi force-pushed the 01-15-_devoverlay_gather_feedback_per_error branch from 4a0c516 to bd83fa0 Compare January 16, 2025 12:40
@devjiwonchoi devjiwonchoi changed the base branch from 01-15-_devoverlay_keep_pagination_on_build_error to graphite-base/74908 January 16, 2025 16:42
@devjiwonchoi devjiwonchoi force-pushed the 01-15-_devoverlay_gather_feedback_per_error branch from bd83fa0 to 279cbd2 Compare January 16, 2025 16:43
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74908 to canary January 16, 2025 16:43
@devjiwonchoi devjiwonchoi force-pushed the 01-15-_devoverlay_gather_feedback_per_error branch from 279cbd2 to 003a61d Compare January 16, 2025 16:43
@devjiwonchoi devjiwonchoi merged commit 2c7bd71 into canary Jan 16, 2025
133 checks passed
Copy link
Member Author

Merge activity

  • Jan 16, 12:00 PM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi deleted the 01-15-_devoverlay_gather_feedback_per_error branch January 16, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants