Fix linting between lint-check and lint-staged #74503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Next.js team
|
All broken links are now fixed, thank you! |
styfle
reviewed
Jan 3, 2025
styfle
reviewed
Jan 3, 2025
| @@ -34,7 +34,7 @@ | |||
| "git-clean": "git clean -d -x -e node_modules -e packages -f", | |||
| "typescript": "tsc --noEmit", | |||
| "lint-typescript": "turbo run typescript", | |||
| "lint-eslint": "cross-env ESLINT_USE_FLAT_CONFIG=false eslint . --ext js,jsx,ts,tsx --config .eslintrc.cli.json --no-eslintrc", | |||
| "lint-eslint": "cross-env ESLINT_USE_FLAT_CONFIG=false eslint . --ext js,jsx,mjs,ts,tsx,mts,mdx --config .eslintrc.json --no-eslintrc", | |||
There was a problem hiding this comment.
Should we delete the .eslintrc.cli.json file now that its unused?
There was a problem hiding this comment.
I think that is meant for use with vscode to not apply as many checks.
There was a problem hiding this comment.
How would vscode know to use that file? 🤔
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
styfle
reviewed
Jan 3, 2025
| @@ -232,7 +232,7 @@ | |||
| "parser": "eslint-mdx", | |||
| "rules": { | |||
| "react/jsx-no-undef": "off", | |||
| "react/self-closing-comp": "error" | |||
| "react/self-closing-comp": "off" | |||
There was a problem hiding this comment.
Not sure if you intended to change this but its probably fine
styfle
approved these changes
Jan 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we match our linting checks between
lint-stagedand ourlint-eslintstep as previously we weren't linting all the files we should have been leading to errors showing up whenlint-stagewould run but not when our normal lint step ran.x-ref: slack thread