Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): no-html-link in appDir #68770

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Conversation

DerTimonius
Copy link
Contributor

@DerTimonius DerTimonius commented Aug 11, 2024

supersedes #51783

What

This PR fixes the issue of <a> tags for internal routing not being caught by linting in the app directory.

Why

The linting of the html links should be consistent across pages and app directories.

How

  • Added a new function to parse the URLs in the appDir (since it's a bit different from the /pages directory)
  • Lint now checks against pagesUrls and appUrls
  • Added tests for the appDir in the no-html-link-for-pages test file

fixes #51742

@ijjk
Copy link
Member

ijjk commented Aug 11, 2024

Allow CI Workflow Run

  • approve CI run for commit: b5aa08b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@DerTimonius
Copy link
Contributor Author

@ijjk is there something missing to get the CI approved?

@DerTimonius
Copy link
Contributor Author

@leerob maybe you can help in getting this reviewed?

@ijjk ijjk merged commit c07dbd7 into vercel:canary Sep 17, 2024
85 checks passed
@github-actions github-actions bot added the locked label Oct 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@next/next/no-html-link-for-pages doesn't work with app router
2 participants