Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pages-dir): cannot load the same css module with both import and next/dynamic #68396

Draft
wants to merge 38 commits into
base: canary
Choose a base branch
from
Draft

fix(pages-dir): cannot load the same css module with both import and next/dynamic #68396

wants to merge 38 commits into from

Commits on Nov 4, 2024

  1. test: add current behavior

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8404cfa View commit details
    Browse the repository at this point in the history

  2. fix: include dynamic css to build manifest

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    22e7be6 View commit details
    Browse the repository at this point in the history

  3. flatten build manifest 

    Co-authored-by: Jiachi Liu <inbox@huozhi.im>
    @devjiwonchoi @huozhi
    devjiwonchoi and huozhi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    035d1e7 View commit details
    Browse the repository at this point in the history

  4. add dynamic import test

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    084ef8a View commit details
    Browse the repository at this point in the history

  5. infer types

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    de80266 View commit details
    Browse the repository at this point in the history

  6. better explanation comment

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0352928 View commit details
    Browse the repository at this point in the history

  7. recursive block

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8eaf2e1 View commit details
    Browse the repository at this point in the history

  8. test: build-manifest test

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    56a0ce3 View commit details
    Browse the repository at this point in the history

  9. ssr false

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8256154 View commit details
    Browse the repository at this point in the history

  10. remove unnecessary pages check 

    [no ci]

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
    @devjiwonchoi @huozhi
    devjiwonchoi and huozhi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c44ac2a View commit details
    Browse the repository at this point in the history

  11. test: add green button

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b142c15 View commit details
    Browse the repository at this point in the history

  12. fix

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    66bfc12 View commit details
    Browse the repository at this point in the history

  13. test: simplify

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b41ce53 View commit details
    Browse the repository at this point in the history

  14. [no ci] update test

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c2088b9 View commit details
    Browse the repository at this point in the history

  15. mini css

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7a7af27 View commit details
    Browse the repository at this point in the history

  16. revert build-manifest but types

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    39a70ed View commit details
    Browse the repository at this point in the history

  17. mini css

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c1e5b0a View commit details
    Browse the repository at this point in the history

  18. no build-manifest

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    86497b0 View commit details
    Browse the repository at this point in the history

  19. clean up mini css

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7f861e9 View commit details
    Browse the repository at this point in the history

  20. remove data-n-p only if is in build manifest

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    99423fa View commit details
    Browse the repository at this point in the history

  21. wip

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a00eb34 View commit details
    Browse the repository at this point in the history

  22. nope, wrong

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a87e689 View commit details
    Browse the repository at this point in the history

  23. separate dynamic import test 

    [no ci]
    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5dab6d1 View commit details
    Browse the repository at this point in the history

  24. fix

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0b89b9e View commit details
    Browse the repository at this point in the history

  25. Revert "infer types" 

    This reverts commit 85c2565.
    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a0501de View commit details
    Browse the repository at this point in the history

  26. revert unnecessary change

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bb15770 View commit details
    Browse the repository at this point in the history

  27. test: edge

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    957e6a3 View commit details
    Browse the repository at this point in the history

  28. pages only

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bb1c11e View commit details
    Browse the repository at this point in the history

  29. test

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a499524 View commit details
    Browse the repository at this point in the history

  30. add repro for dynamic import

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e0103d7 View commit details
    Browse the repository at this point in the history

  31. add route to react-loadable-manifest

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    9e66b9c View commit details
    Browse the repository at this point in the history

  32. dynamic css

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3357596 View commit details
    Browse the repository at this point in the history

  33. test 

    [no ci]
    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e2af950 View commit details
    Browse the repository at this point in the history

  34. revert

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    472c4f9 View commit details
    Browse the repository at this point in the history

  35. revert unnecessary changes

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cb454cf View commit details
    Browse the repository at this point in the history

  36. on demand

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    24017ac View commit details
    Browse the repository at this point in the history

  37. on demand

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0373d75 View commit details
    Browse the repository at this point in the history

  38. uninteded during rebase

    @devjiwonchoi
    devjiwonchoi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f3ae3db View commit details
    Browse the repository at this point in the history