fix: #68259 set authors in openGraph of metadata to empty string will be crash with SSR #68151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
tuberrabbit
force-pushed
the
opengraph_authors
branch
from
9a80ac9
to
11dc68f
Compare
tuberrabbit
force-pushed
the
opengraph_authors
branch
from
11dc68f
to
6ffb6ba
Compare
|
@tuberrabbit Hi, could you first open an issue with a reproduction? Thank you! |
tuberrabbit
changed the title
tuberrabbit
changed the title
tuberrabbit
changed the title
Hi, I've updated now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug #68259
According to the official Next.js documentation, developers can set the authors field in the openGraph metadata, and the type accepts either a string or a URL. However, when I attempted to do this, server-side rendering would crash with the error “r.map is not a function” because the actual code execution forcefully asserts that this authors field is of type string[]. This pull request fixes this issue and provides a warning comment.
Feel free to let me know if you need any adjustments!