Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace indexOf === 0 with startsWith #68116

Merged
merged 2 commits into from
Aug 1, 2024
Merged

refactor: replace indexOf === 0 with startsWith #68116

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bce62b
refactor(webpack/loaders): replace `indexOf === 0` with `startsWith`
Juneezee Jul 24, 2024
5c68bd8
Merge branch 'canary' into refactor/replace-indexOf-with-startsWith
samcx Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next/src/build/webpack/loaders/css-loader/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function normalizeSourceMap(map: any, resourcePath: string) {
// We should normalize path because previous loaders like `sass-loader` using backslash when generate source map
newMap.sources = newMap.sources.map((source: string) => {
// Non-standard syntax from `postcss`
if (source.indexOf('<') === 0) {
if (source.startsWith('<')) {
return source
}

Expand Down Expand Up @@ -297,7 +297,7 @@ function normalizeSourceMapForRuntime(map: any, loaderContext: any) {

resultMap.sources = resultMap.sources.map((source: string) => {
// Non-standard syntax from `postcss`
if (source.indexOf('<') === 0) {
if (source.startsWith('<')) {
return source
}

Expand Down
2 changes: 1 addition & 1 deletion packages/next/src/build/webpack/loaders/postcss-loader/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function normalizeSourceMapAfterPostcss(map: any, resourceContext: string) {

// eslint-disable-next-line no-param-reassign
newMap.sources = newMap.sources.map((source: string) => {
if (source.indexOf('<') === 0) {
if (source.startsWith('<')) {
return source
}

Expand Down
2 changes: 1 addition & 1 deletion .../next/src/client/components/react-dev-overlay/internal/helpers/format-webpack-messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function formatMessage(
}

// Cleans up verbose "module not found" messages for files and packages.
if (lines[1] && lines[1].indexOf('Module not found: ') === 0) {
if (lines[1] && lines[1].startsWith('Module not found: ')) {
lines = [
lines[0],
lines[1]
Expand Down
Loading