Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/form #68102

Merged
merged 45 commits into from
Jul 30, 2024
Merged

next/form #68102

merged 45 commits into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. next/form: initial implementation

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1dc69c8 View commit details
    Browse the repository at this point in the history

  2. test: basic functionality of next/form

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a9e5767 View commit details
    Browse the repository at this point in the history

  3. fix: navigation to formAction (squash me)

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5e4c200 View commit details
    Browse the repository at this point in the history

  4. fix: more formAction fixes

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    387f34f View commit details
    Browse the repository at this point in the history

  5. test: button with formAction

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bc1cbc8 View commit details
    Browse the repository at this point in the history

  6. scaffolding: edge alias stuff

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1441287 View commit details
    Browse the repository at this point in the history

  7. todo

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3bee299 View commit details
    Browse the repository at this point in the history

  8. handle errors/warnings from server and client actions

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f942a4b View commit details
    Browse the repository at this point in the history

  9. disallow form props: method,encType,target

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    50163ca View commit details
    Browse the repository at this point in the history

  10. call user-provided early onSubmit early and respect preventDefault

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    598e46e View commit details
    Browse the repository at this point in the history

  11. be stricter about disallowed form props

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    229bd24 View commit details
    Browse the repository at this point in the history

  12. basePath support

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e8de9a2 View commit details
    Browse the repository at this point in the history

  13. refactor: pull huge onSubmit callback out

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    41cca4a View commit details
    Browse the repository at this point in the history

  14. wip: prefetch when visible (instead of on mount)

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2613191 View commit details
    Browse the repository at this point in the history

  15. refactor: use useMergedRef

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c50dea3 View commit details
    Browse the repository at this point in the history

  16. add "scroll" prop to Form

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    34b5db4 View commit details
    Browse the repository at this point in the history

  17. fix: match native behavior for file inputs

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    01e63d5 View commit details
    Browse the repository at this point in the history

  18. warn about search params in action

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    614fb72 View commit details
    Browse the repository at this point in the history

  19. warn about "replace" and "scroll" if action is a function

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a2d0774 View commit details
    Browse the repository at this point in the history

  20. clean up FormProps and document the props better

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    39e4d96 View commit details
    Browse the repository at this point in the history

  21. improve some error messages

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    846f01b View commit details
    Browse the repository at this point in the history

  22. more helpful error for banned props

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7faddee View commit details
    Browse the repository at this point in the history

  23. todos

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    72bc448 View commit details
    Browse the repository at this point in the history

  24. test: move tests

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    662467c View commit details
    Browse the repository at this point in the history

  25. test: add tests for basePath

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e03aa8d View commit details
    Browse the repository at this point in the history

  26. test: functions passed to formAction

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    be9453f View commit details
    Browse the repository at this point in the history

  27. test: functions passed to action

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bf8741c View commit details
    Browse the repository at this point in the history

  28. test: unsupported attributes on submitter

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    303f960 View commit details
    Browse the repository at this point in the history

  29. todo

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5cf30ef View commit details
    Browse the repository at this point in the history

  30. action validation improvements: don't warn for action="", warn for in… 

    …valid urls
    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f993996 View commit details
    Browse the repository at this point in the history

  31. change "next/form" to "<Form>" in error messages to match Link

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d01ff22 View commit details
    Browse the repository at this point in the history

  32. remove TODO 

    we don't need to do anything about validation, because if
form validation doesn't pass, onSubmit will not trigger
https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/submit_event#sect1
    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    912e4d4 View commit details
    Browse the repository at this point in the history

  33. add some whatwg spec references for weird behaviors

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d36ffaa View commit details
    Browse the repository at this point in the history

  34. fix: avoid dynamic requests in prefetch (prefetchKind: auto)

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b0d83ab View commit details
    Browse the repository at this point in the history

  35. refactor: deduplicate "typeof actionProp" checks

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0d65f1e View commit details
    Browse the repository at this point in the history

  36. fix: resolve "action" relative to location.href 

    (instead of document.baseURI, for consistency)
    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3c2bcc0 View commit details
    Browse the repository at this point in the history

  37. leave file input test for later

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2847d38 View commit details
    Browse the repository at this point in the history

  38. test: replace prop

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f49d59b View commit details
    Browse the repository at this point in the history

  39. test: preventDefault in onSubmit

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f0a4dfc View commit details
    Browse the repository at this point in the history

  40. test: enable for deployment

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7f8b0f5 View commit details
    Browse the repository at this point in the history

  41. refactor: common logic for asserting we didn't hard-navigate

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    331ca4d View commit details
    Browse the repository at this point in the history

  42. remove unnecessary TODO

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    da580dc View commit details
    Browse the repository at this point in the history

  43. fix: validation message for scroll/replace

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1f6bb86 View commit details
    Browse the repository at this point in the history

  44. remove unnecessary test skip logic

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    850d6f6 View commit details
    Browse the repository at this point in the history

  45. test: add test for file inputs

    @lubieowoce
    lubieowoce committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b854edf View commit details
    Browse the repository at this point in the history