Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nested-components example to use App Router #68065

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

Shruthireddy04
Copy link
Contributor

This PR updates the nested-components example to use the App Router. Here are the changes that have been made:

Renamed the "pages" folder to "app" folder.
Updated the file index.tsx to page.tsx to align with App Router.
Added the layout.tsx file as part of the App Router.
Updated the components folder to align with App Router and made components folder private.
Updated package.json to use the latest version.

cc: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Jul 23, 2024
@ijjk
Copy link
Member

ijjk commented Jul 23, 2024

Allow CI Workflow Run

  • approve CI run for commit: 97f99ca

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx self-requested a review July 24, 2024 13:56
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) July 24, 2024 13:58
@samcx samcx disabled auto-merge July 24, 2024 13:59
@samcx
Copy link
Member

samcx commented Jul 24, 2024

@Shruthireddy04 Is there a reason why the jsx was removed with the style jsx styles?

@Shruthireddy04
Copy link
Contributor Author

@samcx According to docs css in js can be used only in client components but here component is not performing any client operations so instead of making it client component removed jsx.

@samcx
Copy link
Member

samcx commented Jul 25, 2024

@Shruthireddy04 I switched it to CSS modules because there were hydration issues going on.

@samcx samcx merged commit fcdf5a9 into vercel:canary Jul 25, 2024
34 checks passed
@github-actions github-actions bot added the locked label Aug 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants