feat(cna): add --turbo flag and prompt for enabling Turbopack dev
#65925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
create-next-app
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
devjiwonchoi
commented
May 18, 2024
| @@ -222,4 +223,32 @@ describe.skip('create-next-app --app (App Router)', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| it('should enable turbopack on --turbo flag', async () => { | |||
There was a problem hiding this comment.
The test passes, but the describe on top is skipped since #65845
There was a problem hiding this comment.
hello good work ❤️ , I did a study, I wonder how your test coverage does not get stuck in timeout, I saw that you also got stuck in timeout
devjiwonchoi
requested review from
a team,
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
devjiwonchoi
requested review from
ismaelrumzan and
jh3y
and removed request for
a team
devjiwonchoi
commented
May 18, 2024
| @@ -272,6 +279,7 @@ async function run(): Promise<void> { | |||
| importAlias: '@/*', | |||
| customizeImportAlias: false, | |||
| empty: false, | |||
| turbo: false, | |||
There was a problem hiding this comment.
default value false until areweturboyet 100
devjiwonchoi
commented
May 18, 2024
|
Closing as duplicate of #65926 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65924