-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update edge-dynamic-code-evaluation.mdx #64844
Conversation
Following the `MiddlewareConfig` typings, this is now named as `unstable_allowDynamicGlobs`
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still parse it as unstable_allowDynamic
not unstable_allowDynamicGlobs
:
next.js/packages/next/src/build/analysis/get-page-static-info.ts
Lines 404 to 421 in 1e3a1cb
if (config.unstable_allowDynamic) { | |
result.unstable_allowDynamicGlobs = Array.isArray( | |
config.unstable_allowDynamic | |
) | |
? config.unstable_allowDynamic | |
: [config.unstable_allowDynamic] | |
for (const glob of result.unstable_allowDynamicGlobs ?? []) { | |
try { | |
picomatch(glob) | |
} catch (err) { | |
throw new Error( | |
`${pageFilePath} exported 'config.unstable_allowDynamic' contains invalid pattern '${glob}': ${ | |
(err as Error).message | |
}` | |
) | |
} | |
} | |
} |
Our tests also use unstable_allowDynamic
not unstable_allowDynamicGlobs
: https://github.com/vercel/next.js/blob/1e710ab73ce6b6ee896535ef0962956aac2e9649/test/integration/edge-runtime-configurable-guards/test/index.test.js
Is the MiddlewareConfig
you linked reachable from usercode or do we document that this is the type you should export your config
as?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: nevermind
Not documented but reachable from usercode
|
Hi folks, caught regression issue with |
@elartix That appears to be solved with #73732. As mentioned above, the config option is still |
Following the
MiddlewareConfig
typings, this is now named asunstable_allowDynamicGlobs