Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert "Apply react-server condition for pages api (#57459)" #57500

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

feedthejim
Copy link
Contributor

This reverts commit 6b18f39.

@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-57459-pages-api-react-server Change
buildDuration 10.8s 10.9s N/A
buildDurationCached 6.1s 6.2s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +352 B
nextStartRea..uration (ms) 397ms 415ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert-57459-pages-api-react-server Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 252 B 248 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-57459-pages-api-react-server Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-57459-pages-api-react-server Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-57459-pages-api-react-server Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-57459-pages-api-react-server Change
index.html gzip 527 B 530 B N/A
link.html gzip 541 B 543 B N/A
withRouter.html gzip 524 B 525 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js revert-57459-pages-api-react-server Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js revert-57459-pages-api-react-server Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 06ba502

@feedthejim feedthejim merged commit 3e7f96e into canary Oct 26, 2023
49 of 54 checks passed
@feedthejim feedthejim deleted the revert-57459-pages-api-react-server branch October 26, 2023 11:37
huozhi added a commit that referenced this pull request Oct 26, 2023
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants