Remove obsolete webpack plugins #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Sep 14, 2018
HaNdTriX
force-pushed
the
webpack-mode
branch
2 times, most recently
from
2a31a0e
to
cc65c94
Compare
timneutkens
reviewed
Sep 14, 2018
| @@ -222,6 +222,14 @@ describe('Production Usage', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('process.env', () => { | |||
There was a problem hiding this comment.
Can we add the same test for development too 👍
There was a problem hiding this comment.
Basically copy this test into the basic test suite
HaNdTriX
force-pushed
the
webpack-mode
branch
3 times, most recently
from
762b744
to
95b08d5
Compare
HaNdTriX
force-pushed
the
webpack-mode
branch
from
95b08d5
to
73d2935
Compare
timneutkens
approved these changes
Sep 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are now using webpacks
modeflag we can get rid of:webpack.optimize.ModuleConcatenationPluginwebpack.DefinePlugin(process.env.NODE_ENV)https://webpack.js.org/concepts/mode/