Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note explaining how to import fonts with spaces in name #46348

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Add note explaining how to import fonts with spaces in name #46348

merged 3 commits into from
Feb 24, 2023

Conversation

jankaifer
Copy link
Contributor

@jankaifer jankaifer commented Feb 24, 2023 •
edited by timneutkens
Loading

Fixes: #45916

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

fix #45916
fix NEXT-555 (link)

@kodiakhq kodiakhq bot merged commit 3997b50 into vercel:canary Feb 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEXT-555] Docs: Missing example for importing a Google Font with a space in the font title
2 participants
@jankaifer @ijjk