Updates cms-sanity example to use Sanity v3 (#45662 #45662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snorrees
requested review from
timneutkens,
ijjk,
shuding,
styfle,
leerob,
steven-tey,
balazsorban44 and
jankaifer
as code owners
snorrees
commented
Feb 7, 2023
leerob
reviewed
Feb 7, 2023
leerob
approved these changes
Feb 9, 2023
leerob
reviewed
Feb 22, 2023
leerob
previously approved these changes
Feb 22, 2023
auto-merge was automatically disabled
February 22, 2023 13:45
Head branch was pushed to by a user without write access
leerob
previously approved these changes
Feb 23, 2023
|
please merge this update, it fixes many issues |
1 task
|
Looks like there's a merge conflict 🙏 |
# Conflicts: # examples/cms-sanity/pages/index.js # examples/cms-sanity/pages/posts/[slug].js
snorrees
requested review from
jankaifer and
leerob
and removed request for
jankaifer
timneutkens
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #numbercontributing.mdFixes issues reported, for instance here: vercel/community#1449
(The example does not deploy atm and uses an old version of Sanity).
Feature
fixes #numbercontributing.md]Testing
Tested using this deploy url (uses the branch from the forke repo):
https://vercel.com/new/clone?repository-url=https%3A%2F%2Fgithub.com%2Fsanity-io%2Fnext.js%2Ftree%2Fsanity-v3%2Fexamples%2Fcms-sanity&repository-name=cms-sanity&project-name=cms-sanity&demo-title=Blog+using+Next.js+%26+Sanity&demo-description=On-demand+ISR%2C+sub-second+as-you-type+previews&demo-url=https%3A%2F%2Fnext-blog-sanity.vercel.app%2F&demo-image=https%3A%2F%2Fuser-images.githubusercontent.com%2F110497645%2F182727236-75c02b1b-faed-4ae2-99ce-baa089f7f363.png&integration-ids=oac_hb2LITYajhRQ0i4QznmKH7gx
Documentation / Examples
pnpm build && pnpm lintfixes #46450